[contract_payment_auto] Lack of robustness - missing commits after each payment (?) about contract

[pedrobaeza]

No, that's not a good technique. You should never commit inside a transaction, or you can have an inconsistent situation.

[fcayre]

Hello @pedrobaeza thanks for your answer. However, present issue describes a problem (global rollback of operations that are independent by nature) which is not solved, so I don't think it should be closed so fast as there is room for improvement here.

The AccountAnalyticAccount.cron_recurring_create_invoice method from contract/models/account_analytic_account.py might be the right place to use the api.Environment.manage context manager mentioned in https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#never-commit-the-transaction to create isolated valid transactions (one for each contract).

What do you think?

[pedrobaeza]

@nhomar why do you reopen? You know that there should never be a commit in the middle of the operation.

[pedrobaeza]

Closing as there's an opened PR about this and being discussed there.