Bug: `WorkspaceItem.getContainer()` always returns the root container about obsidian-api

[liamcain]

getContainer is working as intended, it is meant to help distinguish between tabs that are inside a sidebar from tabs in the main area of the window.

Instead of getContainer() what you actually want to access is leaf.parent which doesn't appear to be exposed in the API. To find the parent WorkspaceSplit, you need to traverse up the workspace tree and find the closest split.

const chatViewLeaves = workspace.getLeavesOfType(VIEW_TYPE_NOTE_CHAT)
if (chatViewLeaves.length > 0) {
  const tabGroup = chatViewLeaves[0].parent;
  leaf = workspace.createLeafInParent(tabGroup, 1);
  // ...rest of the view creation logic
}

Note: this code will throw errors in your editor, so you'll need to use @ts-ignore for now

[ofalvai]

Thank you @liamcain, I tried the suggested snippet, and even though the returned split instance is correct (I double-checked the DOM reference in devtools), the end result is still the same: my custom view is directly attached to the root split without any tab UI. Is it possible that createLeafInParent() can't create tab leaves and it is hardcoded to create a child of a split?

I double-checked the workspace.json structure on disk, and it matches what I see on the UI:

{
  "main": {
    "id": "db68a861fda8a4a5",
    "type": "split",
    "children": [
      {
        "id": "07c59eaad420ce86",
        "type": "leaf",
        "state": {
          "type": "llm-note-chat-view",
          "state": {}
        }
      },
      {
        "id": "1b2c279856192e00",
        "type": "tabs",
        "children": [...]
      }
    ]
}

For the record, I also tried workspace.duplicateLeaf(chatViewLeaves[0], "tab") and it gives the same result.
Edit: nevermind, I made a mistake. duplicateLeaf() does something different: it creates a tab leaf, but in the wrong split leaf, not the one where chatViewLeaves[0] is.

[liamcain]

@ofalvai Oh, sorry. I think I confused myself when writing that code before. You aren't trying to add a tab to the WorkspaceSplit, you're trying to add a tab to the tab group. In that case, its even simpler. I updated my code snippet above to do what you're after.

[ofalvai]

Oh, that makes sense, thank you. I was so focused for what to do with the parent reference that I didn't see the problem with the while loop 😵‍💫