Coder Social home page Coder Social logo

Comments (15)

kaolin avatar kaolin commented on August 27, 2024 13

FWIW ~

diff --git a/node_modules/react-native-collapsible/index.d.ts b/node_modules/react-native-collapsible/index.d.ts
index 26f8d56..7acf736 100644
--- a/node_modules/react-native-collapsible/index.d.ts
+++ b/node_modules/react-native-collapsible/index.d.ts
@@ -93,6 +93,12 @@ export interface CollapsibleProps {
    * Function called when the animation finished
    */
   onAnimationEnd?: () => void;
+
+  /**
+   * Children! https://github.com/oblador/react-native-collapsible/issues/436
+   */
+  children?: React.ReactNode;
+
 }

 export default class Collapsible extends React.Component<CollapsibleProps> {}

from react-native-collapsible.

teyalite avatar teyalite commented on August 27, 2024 9

@MikeyAlmighty yes, i added the child prop to it in the source file in node_modules

from react-native-collapsible.

doug-shontz avatar doug-shontz commented on August 27, 2024 3

I see this has been merged in a PR. #432. Could it please be published?

from react-native-collapsible.

Andreas-Sujono avatar Andreas-Sujono commented on August 27, 2024 1

@oblador still get this issue

from react-native-collapsible.

kvika-kristin avatar kvika-kristin commented on August 27, 2024 1

@oblador This is still causing a problem, would it be possible to publish a new version including the fix that was merged in #432 ?

from react-native-collapsible.

mohandarsi avatar mohandarsi commented on August 27, 2024

image

from react-native-collapsible.

MikeyAlmighty avatar MikeyAlmighty commented on August 27, 2024

Hi @teyalite Did you find a potential workaround for this?

from react-native-collapsible.

kubik369 avatar kubik369 commented on August 27, 2024

This is due to the update to React 18, where children props need to be stated in the type explicitly.

@oblador Would you accept a PR with this single change? AFAIK it does not affect older versions. Thanks for the reply :)

from react-native-collapsible.

marioacero avatar marioacero commented on August 27, 2024

@oblador could you add that fix?

from react-native-collapsible.

makarewicz77 avatar makarewicz77 commented on August 27, 2024

I'm also facing the issue and would appreciate a fix for this one. I'm not considering changing the index.d.ts from node_modules as a proper solution.

from react-native-collapsible.

bobness avatar bobness commented on August 27, 2024

Same. Please fix! I'll put @ts-expect-error for now... 👿

from react-native-collapsible.

oscar-shamrock avatar oscar-shamrock commented on August 27, 2024

this has been fixed?

from react-native-collapsible.

oscar-shamrock avatar oscar-shamrock commented on August 27, 2024

ii saw is merged but when i install the package is not fixed

from react-native-collapsible.

bads77 avatar bads77 commented on August 27, 2024

Hi, any plans on fixing this?

from react-native-collapsible.

stevekuznetsov avatar stevekuznetsov commented on August 27, 2024

Looks like v1.6.1 released that fix. @oblador we can close this issue out!

from react-native-collapsible.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.