Comments (7)
@egouldo Thank you so much for your awesome contribution, and my sincere apologies it took me that long to get around and take a look. As you might see in the history, I didn't do any development on this package for quite a while, but now I'm pushing some things forward, including your UI!
I don't know how to repay your efforts, but do let me know if you have an idea. What I can do is give some feedback on your code @clairemiller (can't tag Mark
During my review of the code, I made some style changes and wording changes, and refactoring, see nuest@5d54092
- I am not an experiences Shiny/Addin developer, so for easier understandability (thinking about future me) I used explicit labels for the functions
- Capitalising
Dockerfile
- Spaces around
=
, space after,
in function argument list, use<-
for object assignments and=
for argument assignments - use the same type of quote character (not mixing
"
and'
) - added a file
common.R
to have one share place to reduce duplication of code statements, e.g. thevolumes <-
definition for file opening dialogs. - some aligning of function names (e.g. in
addin.R
) - use
basename
to get directory name instead of regex - Put
shiny::stopApp()
at the same spot in all event functions - rename script files
I created an issue to develop the UI further: #147 Let me know what you think!
Again: đ đ¯ â¤ī¸ Thank you! đ
from containerit.
Hi @nuest - a group of us at ropensci oz unconference 2018 are going start hacking at a few issues on containerit, including this one! Our fork and issue branch is here: https://github.com/ropenscilabs/containerit/tree/Issue27_GUI. Let us know if you have any thoughts on this one.
from containerit.
Thakns @smwindecker ! That's great! Apologies for not getting back to you sooner. I will take a look soon. I guess master...ropenscilabs:master replaces #134 ?
from containerit.
Hey @nuest, I ended up working on a separate part of this project. Can't tag Elise Gould for some reason but she led this team so I'll nudge her in person to check your question.
from containerit.
Thanks for alerting me to this @smwindecker. That's correct, @nuest!
from containerit.
Investigating https://github.com/o2r-project/containerit/pull/146/files now.
from containerit.
@egouldo @clairemiller please check if I got your ORCIDs right in the DESCRIPTION
file: https://github.com/o2r-project/containerit/blob/dev/DESCRIPTION
from containerit.
Related Issues (20)
- File not found using CMD_RScript to run the R script on start-up HOT 1
- E: Repository 'http://cdn-fastly.deb.debian.org/debian testing InRelease' changed its 'Codename' value from 'buster' to 'bullseye' HOT 1
- Evaluate dockerfiler for creation of Dockerfile
- Custom COPY additions not exported HOT 3
- Fix installed package detection for plumber image
- dockerfile adding a make depedency on Windows vs not on OSX HOT 3
- Compare remotes::install_version(..) with versions::install.versions(..)
- Add support for Alpine base images
- Add option to use hadley/requirements instead of document execution
- Add support for renv HOT 2
- Evaluate rstudio/r-system-requirements
- Re-use output parameters of R Markdown headers as part of CMD_Render
- Typos in containerit.Rmd HOT 8
- Add option to use attachment for finding dependencies
- Reticulate and python dependencies
- Create a target factory / integration with the targetopia
- Try out system requirements function from package remotes
- Switch tests to r-ci
- DESCRIPTION without Depends
- Sysreqs calls are too many if lots of deps HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
đ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. đđđ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google â¤ī¸ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from containerit.