Coder Social home page Coder Social logo

Comments (7)

nuest avatar nuest commented on May 20, 2024 1

@egouldo Thank you so much for your awesome contribution, and my sincere apologies it took me that long to get around and take a look. As you might see in the history, I didn't do any development on this package for quite a while, but now I'm pushing some things forward, including your UI!

I don't know how to repay your efforts, but do let me know if you have an idea. What I can do is give some feedback on your code @clairemiller (can't tag Mark ☚ī¸ )

During my review of the code, I made some style changes and wording changes, and refactoring, see nuest@5d54092

  • I am not an experiences Shiny/Addin developer, so for easier understandability (thinking about future me) I used explicit labels for the functions
  • Capitalising Dockerfile
  • Spaces around =, space after , in function argument list, use <- for object assignments and = for argument assignments
  • use the same type of quote character (not mixing " and ')
  • added a file common.R to have one share place to reduce duplication of code statements, e.g. the volumes <- definition for file opening dialogs.
  • some aligning of function names (e.g. in addin.R)
  • use basename to get directory name instead of regex
  • Put shiny::stopApp() at the same spot in all event functions
  • rename script files

I created an issue to develop the UI further: #147 Let me know what you think!

Again: 👍 đŸ’¯ ❤ī¸ Thank you! 🚀

image

from containerit.

smwindecker avatar smwindecker commented on May 20, 2024

Hi @nuest - a group of us at ropensci oz unconference 2018 are going start hacking at a few issues on containerit, including this one! Our fork and issue branch is here: https://github.com/ropenscilabs/containerit/tree/Issue27_GUI. Let us know if you have any thoughts on this one.

from containerit.

nuest avatar nuest commented on May 20, 2024

Thakns @smwindecker ! That's great! Apologies for not getting back to you sooner. I will take a look soon. I guess master...ropenscilabs:master replaces #134 ?

from containerit.

smwindecker avatar smwindecker commented on May 20, 2024

Hey @nuest, I ended up working on a separate part of this project. Can't tag Elise Gould for some reason but she led this team so I'll nudge her in person to check your question.

from containerit.

egouldo avatar egouldo commented on May 20, 2024

Thanks for alerting me to this @smwindecker. That's correct, @nuest!

from containerit.

nuest avatar nuest commented on May 20, 2024

Investigating https://github.com/o2r-project/containerit/pull/146/files now.

from containerit.

nuest avatar nuest commented on May 20, 2024

@egouldo @clairemiller please check if I got your ORCIDs right in the DESCRIPTION file: https://github.com/o2r-project/containerit/blob/dev/DESCRIPTION

from containerit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤ī¸ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.