Comments (4)
Committing the binary into version control is highly discouraged and unsustainable. The repository is over 140 megabytes, and will continue to grow at a huge pace indefinitely. It also took me 14 minutes to clone it, so the build-time benefits are arguable.
They are useful. Building gotk3 library on my laptop takes 15 minutes.
Running go build
re-builds gotk3 (and everything else) again upon the next build anyway, so this really only helps someone cloning the repository with no intention of making any code changes. Sounds like what you want is to just publish artefacts.
It's easy to skip building, just by removing this step from PKGBUILD.
If your intent is to use the binaries for packages, you'd probably be better off using something like GitHub actions to build them and downloading those artefacts. I don't think you don't need to version-control each build and retain them indefinitely. Each build is 7MiB, so each time you commit a build the repository will grow by the amount each time (git doesn't really handle diffing binaries).
from nwg-drawer.
They are useful. Building gotk3 library on my laptop takes 15 minutes. It's easy to skip building, just by removing this step from PKGBUILD.
from nwg-drawer.
I get it, and as a matter of facts it's useful when building locally, but the repo shouldn't track it.
In theory that ELF is intended for x86_64 systems, so what happens if I clone the repo as it is and try to build on an arm system?
Will go discard the already built binary or will it throw out errors and stop the build process?
I was taught that's one reason it's uncommon to maintain built binaries in the repo, but I may have been taught wrong.
For binary distribution, wouldn't it be better if the PKGBUILD pointed to binaries uploaded on the release page?
from nwg-drawer.
Probably. This was just a handy shortcut. Plus I didn't want to maintain separate -bin
packages.
from nwg-drawer.
Related Issues (20)
- Dead icons in nwg-drawer HOT 5
- Dotted lines not in drawer.css HOT 3
- nwg-drawer send string to search from command line HOT 5
- Can't click on waybar when nwg-drawer is open HOT 3
- Issues on touch devices HOT 3
- [CHANGED BEHAVIOR] New installation opens default list differently, can't fix HOT 6
- Uninstalled apps impossible to unpin HOT 1
- Drawer not following CSS with newest update HOT 2
- New option --config HOT 1
- /tmp/nwg-drawer.lock was owned by other user HOT 1
- nwg-drawer upgrade from 0.2.8 to 0.3.0 broke HOT 1
- Non-ascii character problem in menu name shortening HOT 6
- Specify icon theme HOT 7
- Panic when run pkill -USR1 nwg-drawer HOT 6
- Launching thunar from nwg-drawer opens in sway config directory HOT 2
- feature: prefer most used applications HOT 1
- Add CI HOT 2
- Launching certain apps HOT 10
- Change term overriding variable and improve error handling? HOT 4
- Some icons appear smaller and are offset when searching HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nwg-drawer.