Coder Social home page Coder Social logo

Comments (5)

echacko avatar echacko commented on May 22, 2024 2

Hi,

The original show() function displays antenna orientation as | irrespective of the polarization type in single polarization configuration.

I will update my code to fix this issue as well and then submit a pull request.

Thanks for pointing out the new error, I did not check with single polarization configuration.

from sionna.

faycalaa avatar faycalaa commented on May 22, 2024

Hi,

Thank you for reporting this bug.

We could reproduce the error. The fix you have suggested seems to work fine for dual polarization, but always display vertical polarization for the single polarisation configuration.

Do you want to update your code and make a pull request?

from sionna.

echacko avatar echacko commented on May 22, 2024

Hi,

I have made the pull request.

Since this was my first pull request, hope I did everything right.

Thanks

from sionna.

faycalaa avatar faycalaa commented on May 22, 2024

Thank you.

We will review it and merge it.

from sionna.

gmarcusm avatar gmarcusm commented on May 22, 2024

Thanks, fixed in 0.9.1

from sionna.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.