Coder Social home page Coder Social logo

Comments (5)

anon-apple avatar anon-apple commented on June 30, 2024

The fallback light should not be used as an actual light in your project. It is meant to be used as a debugging tool. Not sure what you really mean by this issue, you cannot attach the fallback light to meshes, so is this an issue with the fallback light you're seeing or one with replaced distant lights? I assume you're saying the fallback light has the same issue or something, but I am also not sure what you mean by "parameters flushed in ImGui".

from rtx-remix.

Kamilkampfwagen-II avatar Kamilkampfwagen-II commented on June 30, 2024

The fallback light should not be used as an actual light in your project. It is meant to be used as a debugging tool. Not sure what you really mean by this issue, you cannot attach the fallback light to meshes, so is this an issue with the fallback light you're seeing or one with replaced distant lights? I assume you're saying the fallback light has the same issue or something, but I am also not sure what you mean by "parameters flushed in ImGui".

The main issue is with replaced distant lights, they don't follow the transformation of their parent mesh.
I think the first occurance was with the dynamic sky for CoD 2 by tadpole3159 where he had to use a sphere light to the rotating skybox, because a distant light wouldn't rotate this way.

The latter is that I had a case where I can set sphere fallback light parameters in cheat engine and observe the changes in real time, while not with the distant light variant. I thought this could be related so I also included it as a side note.
"parameters flushed in ImGui" really just means "set in the ui", it works as intended when done through the ui, so I assume doing that does more than just setting the respective variables.

from rtx-remix.

anon-apple avatar anon-apple commented on June 30, 2024

Ah yes, obviously changing things with cheat engine is not going to work. When the light parameters change for the fallback light the light list needs to be refreshed and that is only done when a change is detected through the UI.

Anyways the other issue does sound like a problem as the USD transform should be part of how the light's direction is derived for replaced lights at least.

from rtx-remix.

mmdanggg2 avatar mmdanggg2 commented on June 30, 2024

Here's a short clip of the issue. The distance light doesn't get rotated along with the cube.
video

from rtx-remix.

anon-apple avatar anon-apple commented on June 30, 2024

I see, that missing updated orientation in the PR to fix this makes sense. Good catch.

from rtx-remix.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.