Comments (5)
At first glance:
- enums are a minor annoyance with Python 2.7 since they are not default, but not a big deal to install the enum package.
shlex.quote()
looks like it can be handled bysix
subprocess.DEVNULL
can probably be replaced byos.devnull
.- Will need to take a closer look at
raise e from e
. This was added to support--print-exceptions
, which was a user requested feature.
from hpc-container-maker.
@samcmill Hmm, relying on six
to resolve the shlex.quote
issue seems overkill to me, assuming we're OK with compatibility with only Python 2.7 and 3.3 or newer, since in Python 2.7 we can use pipes.quote
instead, cfr. https://stackoverflow.com/a/26791164/1467322 ?
from hpc-container-maker.
My impression, perhaps incorrect, is that pipes.quote
is deprecated in Python 3 and may be removed at any time. https://docs.python.org/3/library/pipes.html does not mention it, although it's (indirectly) available in the implementation https://github.com/python/cpython/blob/3.6/Lib/pipes.py due to from shlex import quote
.
from hpc-container-maker.
@samcmill I wasn't suggesting to switch to pipes.quote
, but rather to use a construct like:
try:
from shlex import quote # python 3.3
except ImportError:
from pipes import quote # python 2.7
from hpc-container-maker.
Closing. Resolved with merge #28.
from hpc-container-maker.
Related Issues (20)
- Mellanox HPC-X installation error HOT 3
- Upload universal wheel to PyPi HOT 2
- nvshmem building block issue (singularity): nvshmem does not build when flag hydra=True set HOT 1
- nvhpc building block with C++20 library support HOT 9
- Public GPG key error fron nvidia ubuntu repository HOT 2
- Need to update default version of Slurm
- Support for Intel oneAPI HOT 2
- Allow use of CMake binary package for aarch64
- Support for chmod flag in copy primitive
- Newer Miniconda versions aren't accessible via the conda module
- error dockerfile with example hpcbase-nvhpc-openmpi.py HOT 1
- Question on boost.py: Why runtime instructions only copies boost-binary? HOT 2
- ucx() problem with versions with the suffix -rc HOT 6
- Error while using "node:latest" base image on HPCCM HOT 2
- LLVM 15 toolchain cant find omp.h HOT 8
- LLVM trunk version out-of-date HOT 2
- GPG error with MKL building block
- Incompatible with python 3.12
- Create a build_block for micromamba HOT 1
- Building blocks should error if a passed parameter does not match any parameters.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hpc-container-maker.