Coder Social home page Coder Social logo

Comments (4)

idigitopia avatar idigitopia commented on June 18, 2024

Hi Jack,

I figured out the same thing. I think this issue can be fixed by adding these lines in the reset.

player.env.task.gym.simulate(player.env.task.sim)
player.env.task.gym.fetch_results(player.env.task.sim, True)

This way we are always getting the new rigid_body values.

from ase.

mJones00 avatar mJones00 commented on June 18, 2024

I think that this causes another issue since gym.simulate will step all the environments. So maybe it solves the problem for environments that are to be reset, but the other ones that are not done will skip the next state that results from the last action.
So for undone environments, the transition will be like:
instead of state_t, action_t => reset done environments => state_t+1
it becomes:
state_t, action_t => reset done environments and step the simulation => state_t+2
This probably messes up with the dynamics.

from ase.

xbpeng avatar xbpeng commented on June 18, 2024

Yes, unfortunately this causes issues where sometimes the simulation will be advanced by two timesteps instead of one. This will probably hurt the training process by introducing some randomness into the dynamics. I'm not sure what a good solution is in this case with IsaacGym. I'm open to suggestions!

from ase.

liangpan99 avatar liangpan99 commented on June 18, 2024

Hi guys, I fixed this bug, plz see my PR!

from ase.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.