Cannot serve manually an amp page from /amp folder about amp-module

[farnabaz]

Thank you for the report ❤️ . The fix release in v0.5.4

[mfrascati]

@farnabaz I said hooray too fast, unfortunately it does not fix the issue.

It still fails here:

  switch (ampMode) {
    case true:
    case 'only':
      isAMP = true
      ampMode = 'only'
      if (options.amp && hasAMPPrefix) {
        return ctx.error({ statusCode: 404, message: 'This page could not be found' })
      }
      break

Setting mode to hybrid, with both routes handled as separate nuxt pages, is the workaround I found to skip this check for now.

[farnabaz]

Thank you for sample ❤️
Your workaround is the correct way to create amp pages. You don't need to set amp: true in pages under /amp directory. All pages under /amp directory will mark as AMP.

Just to mention, This condition if (options.amp && hasAMPPrefix) {, should be here to prevent generating duplicate page on static generation.

[farnabaz]

This seems an issue of routes generation.

[farnabaz]

Oh I see, my bad.
I was misunderstand your problem (BTW, The outcome is good. I found another issue 😄)

Could you provide a simple reproduction on codesandbox?

[mfrascati]

Sure, I managed to reproduce, breaking the nuxt-amp codesandbox working example 😅

https://codesandbox.io/s/nostalgic-grothendieck-vhf6n

Using the example /hello and /amp/hello routes.
Basically I set mode: false as default in nuxt config, then overridden with amp: true in /amp/hello and now it's broken

[mfrascati]

Oh, I see! Maybe it could be worth mentioning it in the docs? amp: true could be misleading in this case

[farnabaz]

Sure it does. Unfortunately I did not do well in documenting the module. I'll update the docs ASAP.