Coder Social home page Coder Social logo

Comments (4)

tamhd avatar tamhd commented on June 19, 2024

We get incorrect evaluation using M2Scorer as well (please double check).

Hypothesis:

It 's Thursday , is n't it ?

M2 file:

S Thursday , is it not ?
A 0 0|||Mec|||It 's|||REQUIRED|||-NONE-|||0
A 3 5|||Mec|||n't it|||REQUIRED|||-NONE-|||0

Based on my understanding, the reason is the initialization step of the levenshtein matrix. It creates the first row using the index of the hypothesis, i.e: the necessary edits to transform an empty sentence into the hypothesis. I think the start and end of such edits should always be 0.

My proposed solution is to change line 827of file levenshtein.py into:

edit = ("ins", 0, 0, '', second[j-1], 0) # always insert at the beginning

It appears to me that the modification will fix the problem, yet I am not sure whether other errors may arise.

Tam

from m2scorer.

kavehtp avatar kavehtp commented on June 19, 2024

I tried it. The generated edits are correct with the change. Can you make a pull request?

from m2scorer.

tamhd avatar tamhd commented on June 19, 2024

I tried it. The modification does not change the result of the 13 teams participating in CoNLL-2014 shared task (Table 7).

from m2scorer.

kavehtp avatar kavehtp commented on June 19, 2024

OK. Thanks.

from m2scorer.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.