Missing flag argument in git aliases about nu_scripts

[amtoine]

@fnuttens
i'll go ahead and close this issue then 😌

if, after the release, any of you guys can reproduce the error again, please feel free to ping here to reopen 😊

[fdncred]

It definitely works in Linux and does not work in Windows. I just confirmed with the latest main in Windows 11 and WSL Ubuntu.

[fdncred]

Ah, I think I figured it out. It's because of this in git-completions.nu

# Commit changes
export extern "git commit" [
  --all(-a)                                           # automatically stage all modified and deleted files
  --amend                                             # amend the previous commit rather than adding a new one
  --message(-m): string                               # specify the commit message rather than opening an editor
  --no-edit                                           # don't edit the commit message (useful with --amend)
]

So, when this tries to happen

export alias gcam = git commit --all --message

It sees that --message wants a string and pukes.

If I remove the : string it works fine but then finds the next similar problem

Error: nu::parser::missing_flag_param

  × Missing flag argument.
    ╭─[D:\nu_scripts\aliases\git\git-aliases.nu:51:1]
 51 │ export alias gcasm = git commit --all --signoff --message
 52 │ export alias gcb = git checkout -b
    ·                                 ─┬
    ·                                  ╰── flag missing string argument
 53 │ export alias gcd = git checkout develop
    ╰────

[amtoine]

this looks like an issue with the completion of nushell itself to me 🤔

[TechWatching]

Anyone suceeded to make it work or find a workaround?

[amtoine]

@TechWatching
dumping

export alias gcam = git commit --all --message

into the REPL of the latest revision of Nushell appears to work 🤔

[TechWatching]

@amtoine Yet I still have the error using 0.85.0 👉

In my config.nu file I am doing nu_scripts\aliases\git\git-aliases.nu *

[amtoine]

@TechWatching
i'm using 0.85.1 😮

the new release of Nushell goes out in a few hours, can you please try again after updating and keep me updated? 😇

[fnuttens]

@TechWatching @amtoine
Huh very strange I'm also on version 0.85.0 and I don't have this error anymore…

[amtoine]

@TechWatching @amtoine Huh very strange I'm also on version 0.85.0 and I don't have this error anymore…

updates and patches come fast, i'm not really surprised 😉

[TechWatching]

@amtoine still an issue with 0.86 on my windows laptop.

[amtoine]

maybe that's a windows issue? 🤔

[fnuttens]

I'm also using Windows 11 and I don't have the bug, so I reckon it's more subtle than “just” a Windows issue.

[fdncred]

If I start nushell like nu -n I can do

use d:\nu_scripts\aliases\git\git-aliases.nu

without any problems. but with my normal startup, it fails. no clue why.

[fdncred]

It looks like it's a conflict between git-completions.nu and git-aliases.nu

If I use them in this order, there are no issues. I think that means that one command is overwriting another command between these two scripts.