Can/Should we use static list of objects? about 2122-s2

[michael192002]

I used the second approach using ImList; I definitely think that using an ImList to list out the specific Service(s) is much more useful due to its flexibility. As for code complexity, I think it might depend on the individual implementation.

[szeying02]

I used the second approach as well, if the driver could offer more services, it'll be easier to modify just the ImList directly. I find it more flexible than the first approach.

[haoyangw]

I used the second approach too. My rationale for declaring it as a static final is this makes it clearer to other people who read the code that the list of services a Driver offers is a compile-time constant(i.e. services don't change/get modified at runtime), vs if you declare the Services objects individually within a method in which case it's not immediately obvious whether you'll change the Services provided somewhere. So this follows the convention of declaring constants in caps and as static final too.

[calvinseptyanto]

It's better to use the second approach since you can easily compare within NormalCab or PrivateCar class on what is the best fare between the two services, and it will be easier for Booking to track the best fare as well!

[chloeoxe]

The second approach is better as I think it abides by the open-closed principle more closely, meaning that if new drivers are to be added(case 1) or new services are to be added to an existing driver(case 2), it is simpler to code them out since we can just extend the code by creating another class that implements the driver interface for case 1 or add on to the existing ImList of services for a driver for case 2 and there is no need to modify the driver interface at all. Hope this helps!

[shotnothing]

Thanks for the replies guys, I will stick to the latter. I guess my question now shifts to: during PE, would we be marked down for writing the former? It does fulfill all test cases and task.txt specifications, and given the time crunch would it be prudent to write simpler, less futureproof code?

[StanleyMak]

For me, i had a static method:

static ImList createServices() {
ImList services = new ImList<>();
services = services.add(new JustRide()).add(new TakeACab());
return services;
}

so in my NormalCab constructor, i do something like super(String license, int waitingTime, createServices());
Note that the super class is Driver.

Hope this helps!

[mk2905]

It's better code design to use the second approach as in cases where there are more services in the question it might be tedious to go about using the former, but for simplicity and to save time, especially during PAs the first approach will work fine as well.