Comments (9)
@ChrisMaddock I'm reviewing each issue in the light of the upcoming release.
This one IMO should get in. One of us may need to complete it if @ivanli doesn't respond on the PR. It sat idle for a long time, so he may be working on other things by now.
Additionally, the PR would need to be re-reviewed in light of the changes made by PR #30.
In any case, I think this is important enough that it should get into the release.
from nunit-v2-framework-driver.
This was confirmed once but it needs to be re-confirmed because the underlying code has changed quite a bit since the issue was filed.
UPDATE: Confirmed!
from nunit-v2-framework-driver.
Keeping this as a v2 framework driver bug. Since nunitv2 actually has no Explore function the driver will have to build it on top of the framework by loading the entire assembly and subsequently applying the filter.
In fact, this adds a new feature. The rationale here is
-
Not having the feature creates a bug because the engine expects it to be present.
-
Adding the feature in nunitv2 itself makes no sense since it would only ever be used by the adapter.
from nunit-v2-framework-driver.
@ivanli Can you try one of the packages at https://ci.appveyor.com/project/CharliePoole/nunit-v2-framework-driver/builds/31644230/artifacts to see if it works for you?
from nunit-v2-framework-driver.
Hi Charlie, it's been a while since this issue came up and we've moved to nunit v3. I can dig up the old project and give it a go sometime this week. Will update.
from nunit-v2-framework-driver.
@ivanli Yes, it has taken a while. I only now took over this project again, so I'm cleaning up old stuff. If you are able to check it out, that will be handy but if you can't do it easily just let me know.
from nunit-v2-framework-driver.
@CharliePoole Apologies for the delay for getting onto this. I've just re-ran the unit tests on our custom test runner and it now works properly. Also re-confirmed that it fails on V3.8.
Thanks very much for the fix! Looking forward to V3.9 so we can update the test runner on our end as well.
from nunit-v2-framework-driver.
This will be sure to confuse someone in the future - maybe even future me! So...
@ivanli did a PR (#28) which needed a bit more work, so I used his branch to create a new one along with PR #35. That one, however, was automatically closed (I think) when I changed the name of 'master' branch to 'main'. So, I started a new PR (#47), which has now finally been merged.
I believe all the needed changes are in it but I didn't want to risk losing all the work so I merged without waiting for any more review. This can be tested by grabbing the appveyor asset or the latest dev build from myget. If more is found to be needed, please let me know here or file a new bug.
from nunit-v2-framework-driver.
🎉 This issue has been resolved in version 3.9.0 🎉
The release is available on:
from nunit-v2-framework-driver.
Related Issues (20)
- How does this work? HOT 1
- Are v2 addins supported? HOT 2
- Remove nunit.v2.driver.addins? HOT 3
- Event Listener and Report output incorrect or nunit2 test runs HOT 10
- Integrate creation of chocolatey package into the build script
- Is it possible to use this driver along with NUnit.ConsoleRunner? HOT 1
- Explicitness of tests is ignored in the presence of a filter with adding multiple negated categories HOT 10
- Use NUnit V2 Core package rather than hard coded 2.6.4 binaries HOT 18
- V2 Driver does not support id filters HOT 11
- Create a level of support statement HOT 1
- Publish 'dev' builds on MyGet HOT 2
- Run integration tests on packages HOT 1
- Name and Fullname are the same in V3 XML format HOT 4
- Automate GitHub Release Process HOT 1
- Change default branch from master to main HOT 1
- Standardize build scripts for extensions HOT 2
- Automate the GitHub release process HOT 1
- V2 Framework Driver not picked up HOT 1
- Standardize scripts across console and extension repos
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nunit-v2-framework-driver.