Comments (3)
I can't wrap my head around why the loop would ever be infinite. It seems to me that GetDirectoryPath
is guaranteed to either be null or empty once it hits the root node. I can only think that the function is somehow returning the path which was passed in, which is highly doubtful.
Why would a non-parallelizable STA test make this more likely?
from nunit-console.
The comment about non-parallelizable STA tests relates to the original issue that was written against the framework. I suspected that the call to Delete might not return. However, it's irrelevant now that we are talking about the engine tests.
There may no longer be an issue. The only thing that bothers me about that method right now is the use of the name path
for two purposes. It takes some knowledge of C# syntax to understand which value is being used in a given statement.
I think I'd be ready to close this in any case.
from nunit-console.
I just looked a bit into this issue, as and I cannot see how the code could hang. The only problem I can see is that sometimes the Dispose
will not remove the file/folder due to an exception being thrown, or possibly leaving empty folders behind if other threads/processes have a delete share to the file making the Delete
method return before actually deleting the file (see e.g. https://stackoverflow.com/questions/50295265/file-exists-returns-true-after-file-delete).
@nunit/engine-team I propose to delete the class TempResourceFile
since it is currently unused in the project.
from nunit-console.
Related Issues (20)
- Add .NET 8 build for nunit-agent HOT 35
- NUnit.ConsoleRunner.NetCore executes test library under wrong runtime version HOT 6
- Add parameter for .NET installation/binaries directory path HOT 1
- Cannot execute .NET 8 tests that require the Desktop or ASP.NET runtime HOT 4
- Getting "NUnit.Engine.NUnitEngineException : Unable to acquire remote process agent" when using latest official 3.15.5 version against NUnit 4.0.1 under .NET 6, but not when installing into a directory path not containing spaces (+ related .NET 8 problem) HOT 2
- Assert.Multiple test failure stack traces HOT 2
- Run CI on PRs and master HOT 1
- NUnit Console and NUnit Console Runner version 3.17.0 error when running tests vis command line on Mac HOT 6
- Allow one to set the Internal Trace location HOT 1
- Namespace regex matching works only for certain Namespace? HOT 2
- --inprocess bug(?): unable to read the App.config value HOT 5
- ComponentNotRegisteredException when executing test cases using NUnit Console 3.16.3 (Release) HOT 6
- nunit3-console doesn't see nugets from Microsoft.AspNetCore.App HOT 2
- NUnit Console fails to run .NET 8 tests when .NET SDK is not installed HOT 3
- Does Nunit ITestEventListener support async handler for OnTestEvent HOT 2
- Fix for #1182 missing in 3.17 (Don't throw exception when VS Solution contains a .NET Standard assembly) HOT 2
- Console fails against assembly relying on "Microsoft.AspNetCore.App" - incorrect runtimeconfig.json HOT 1
- NUnit.Engine.NUnitEngineException : Unable to acquire remote process agent HOT 2
- Package NUnit.Console 3.15.3 missing from nuget.org HOT 2
- ExtensionManager unable to find extensions in certain situations involving circular references HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nunit-console.