Comments (17)
The FEN in the parsing error not just "doesn't seem to be correct", but is
definitely from another game.
Original comment by gbtami
on 14 Jun 2014 at 6:06
from pychess.
Wow, really weird. Should I post the full log?
Original comment by mattgatto
on 14 Jun 2014 at 6:20
from pychess.
Yes, please. Maybe we can figure out what was the other game.
Original comment by gbtami
on 14 Jun 2014 at 6:59
from pychess.
Original comment by mattgatto
on 14 Jun 2014 at 7:05
Attachments:
from pychess.
Seems there was another junglescrabble vs. Kombo lightning rated game with same
322 game number, started at 16:46:48. One hour before the game emitting parsing
error. It contains the FEN shown in parsing error.
Original comment by gbtami
on 14 Jun 2014 at 8:29
from pychess.
Good catch. I guess we need to filter out board updates based on more than
player names and game number in ICPlayer.__boardUpdate, or just disconnect
ICPlayer's from "boardUpdate" signals after the game ends rather than when the
widget is deleted. The former would be better though, because that way it'll be
easier to add in functionality in the future for game widgets to be able to
resume games after adjournment when the player logs back in. One possibility
would be to add a game start time timestamp FICSGame attribute and use that in
FICSGame.__hash__.
Original comment by mattgatto
on 20 Jun 2014 at 4:33
from pychess.
Unfortunately FICS doesn't send any timestamp info on board updates, so we will
never know which FICSGame got the board update if they have same players and
gameno. I added a "current" flag to the ICPlayer instead, indicating which is
the latest using the same players and gameno.
Original comment by gbtami
on 20 Sep 2014 at 10:55
from pychess.
This issue was closed by revision ca892a01333e.
Original comment by gbtami
on 20 Sep 2014 at 10:56
- Changed state: Fixed
from pychess.
Why do we need FICS to send us timestamp info when we could just use our own
timestamp?
Original comment by mattgatto
on 24 Sep 2014 at 7:12
from pychess.
If we have start time timestamp FICSGame attribute and a message is coming from
FICS we never know which game it belongs to if there are several ones with same
gameno+wplayer+bplayer in our FICSGames.
Original comment by gbtami
on 24 Sep 2014 at 7:26
from pychess.
Couldn't we just assume that the latest board-update corresponds to the
FICSGame with the newest timestamp?
Original comment by mattgatto
on 24 Sep 2014 at 8:04
from pychess.
For games were playing at least.
Original comment by mattgatto
on 24 Sep 2014 at 8:06
from pychess.
Sorry, I forgot this is happened in an observed game.
Original comment by mattgatto
on 24 Sep 2014 at 8:07
from pychess.
Ideally, ICPlayer shouldn't have to figure out whether the board-update applies
to its game, and will only receive board-updates that apply to its game. The
controller, FICSGames, BoardManager, or whatever should figure this out,
possibly by retrieving the applicable game from FICSGames based on the current
FICSGame gameno+wplayer+bplayer hash and doing game.update(update) which would
emit the update only to listeners on that game.
Original comment by mattgatto
on 24 Sep 2014 at 8:25
from pychess.
Original comment by mattgatto
on 24 Sep 2014 at 8:36
- Changed title: remove boardUpdate signal and emit game-updates from FICSGame
- Changed state: Reopened
- Added labels: Type-Task
- Removed labels: Type-Defect
from pychess.
Matt, feel free to fix my fix, please!
Original comment by gbtami
on 24 Sep 2014 at 8:37
from pychess.
Original comment by mattgatto
on 27 Sep 2014 at 12:37
- Changed state: Started
from pychess.
Related Issues (20)
- in ongoing games moves in annotation panel get light black color HOT 6
- python interpreter crash when using FICS HOT 3
- Segmentation error while playing a FICS game HOT 2
- Implement all (new) draw rules
- gamemodel never starts (GameModel.run() isn't entered) sometimes HOT 4
- hint arrow drawing during piece move animation makes animation choppy and slow
- following a player who goes on to play bughouse leads to eventual AttributeError HOT 2
- FICS freeze HOT 2
- Pychess freeze while playing on FICS HOT 3
- FICS crash HOT 2
- game result appears before last move in annotation panel sometimes HOT 1
- IndexError when observing FICS game HOT 3
- PyChess does not start HOT 2
- Play on lichess.org HOT 1
- holding pieces in crazyhouse games not always showing up HOT 3
- FICS python crash: "GC object already tracked" HOT 1
- FICS freeze
- IndexError upon resigning FICS game HOT 3
- Don't show "Play Rematch" button whan game was loaded from .pgn file HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pychess.