Position by data not working with annotationCalloutRect about semiotic

[emeeks]

An example of the "bounds" annotation for XYFrame was added to the interactive docs version of the Apple chart:
https://emeeks.github.io/semiotic/#/semiotic/annotations

Let me know if you have any issues.

[bengarvey]

This issue has rect me

[bengarvey]

Also, this seems like more of a Stack Overflow type question than a github issue. @emeeks what do you think? Do you want to concentrate all feedback here for now, or should we move this kind of stuff somewhere else?

[bengarvey]

I updated to the latest version of semiotic and lots of things broke with my annotations or look weird. Sorting that out now. annotationCalloutRect now seems to throw an error.

[bengarvey]

I had to go back to 1.0.6 to make my charts work again ;)

[emeeks]

Hi Ben I have solutions for you but I haven't published the new version!

The short answer on your last issue was that as of 1.1 Semiotic has moved to react-annotation with the primary problem (and the reason for the minor version bump) being that react-annotation follows React naming conventions, so all your d3-svg-annotation types need capital letters!

[emeeks]

Unfortunately I don't support an interface into Susie's data API in her annotations. I plan to do so in the future so you can use Semiotic syntax or react-annotation syntax. What your example taught me is that I need to have a better default "bounds" annotation type. The current version supports a bounding box, so you could painstakingly calculate the top and bottom and get that effect, but the new version defaults to the extent of the chart for anything not sent to it. As a result you could make your annotation or anything like it. Here I've used it to add a bounded region to the Apple Stock chart example:

The other drawback of the original bounds annotation is that it created custom SVG elements, now it acts as a pass-through to react-annotation's AnnotationCalloutRect like your example.

This is all available in the 1.1.4 which I just published.

[emeeks]

And no, I'd prefer the pioneer tax be paid here on Github. Many of the issues are not StackOverflow type. I'd wait until there are other people besides me who can answer questions before opening up that route.

[bengarvey]

Word.

[bengarvey]

Those examples helped a ton. Upgraded and got everything working again. Thanks!

[emeeks]

Hey that looks like it's working! But all your scummy sketchy lines have been replaced. I feel like somebody got to you.

[bengarvey]

@emeeks It became an issue with one of the reports where I used a stacked area chart. The sketchy area isn't as fun as the sketchy line.