overlap problem about hydrogen

[willwhitney]

This is a problem with the Atom API for markers. I've opened an issue at atom/atom#6857 — I need them to fix it before I can address this, unfortunately.

[willwhitney]

Or rather, I could fix it for us, but at risk of breaking other packages (as I mention on that thread). I think it's unlikely that any packages depend on the exact z-index of the tab bar, so if they don't get a fix done soon I'll just do that.

[willwhitney]

Went ahead and did this. Shipped in v0.4.0!

[X-G]

Thanks Will.

[n-riesco]

This issue is still present in v0.7.1

[n-riesco]

This comment shows the issue clearly.

[rgbkrk]

Block decorations should be the way forward. http://blog.atom.io/2016/02/03/introducing-block-decorations.html

[n-riesco]

@rgbkrk I've tried the following with Atom 1.7.0-dev-7040035 and it doesn't seem to work:

$ git diff
diff --git a/lib/main.coffee b/lib/main.coffee
index 7afdb18..10b2ef0 100644
--- a/lib/main.coffee
+++ b/lib/main.coffee
@@ -159,9 +159,9 @@ module.exports = Hydrogen =
         view.statusContainer.setAttribute('style', "height: #{lineHeight}px")

         @editor.decorateMarker marker,
-            type: 'overlay'
+            type: 'block'
             item: element
-            position: 'tail'
+            position: 'after'

         @markerBubbleMap[marker.id] = view
         marker.onDidChange (event) =>
diff --git a/styles/hydrogen.less b/styles/hydrogen.less
index 5ba24fa..cd98ed4 100644
--- a/styles/hydrogen.less
+++ b/styles/hydrogen.less
@@ -5,20 +5,6 @@
 @import "ui-variables";
 @import "syntax-variables";

-// this is a hack to deal with a failing of the markers API
-// https://github.com/atom/atom/issues/6857
-.tab-bar {
-    z-index: 5;
-}
-
-.bottom{
-    z-index: 4;
-}
-
-atom-overlay.autocomplete-plus {
-  z-index: 6;
-}
-
 .hydrogen.output-bubble {
     @light-bubble-background: fadein(lighten(@syntax-background-color, 40%), 100%);
     @dark-bubble-background: fadein(lighten(@syntax-background-color, 10%), 100%);

[lgeiger]

@n-riesco if you remove this line the result should be displayed. But of course the styling will be totally messed up.

[n-riesco]

@lgeiger Here's how it looks like after removing position: absolute: