Coder Social home page Coder Social logo

Documentation errors/bugs about rosco HOT 2 CLOSED

ghylander avatar ghylander commented on August 24, 2024
Documentation errors/bugs

from rosco.

Comments (2)

dzalkind avatar dzalkind commented on August 24, 2024 2

Thanks for your assistance. All of these are addressed in #54.

In ROSCO, PS_Mode = 1 only enables peak shaving. In the ROSCO_toolbox, we can peak shave using a few methods. We can enable PS_Mode of 2 and 3 in ROSCO, but it will still only act as if PS_Mode = 1. The lookup table is what matters. @nikhar-abbas, I pushed this change, but I'll let you decide whether to keep it.

from rosco.

nikhar-abbas avatar nikhar-abbas commented on August 24, 2024 1

Thanks for pointing all of these out. Because this is an open-source research code, we have limited resources to keep everything in check (especially these smaller things), so it is good to have this feedback from the users/community to help us out.

Do you mind putting together a pull request into the oneROSCO2 branch with these, and any other minor fixes you may see fit? If it is easier, you can combine these updates with whatever solutions you come to as #66 gets resolved.

Thanks,
Nikhar

Edit: leaving this open until these changes are incorporated

from rosco.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.