Coder Social home page Coder Social logo

Comments (5)

usr110 avatar usr110 commented on July 22, 2024

@Robinlovelace I believe it's to do with the fixed height of the map - see here https://github.com/npct/pct-shiny/blob/master/master/ui.R#L33

May be you or @nikolai-b could set it to a relative height. For some reason "100%" doesn't work.

from pct-shiny.

Robinlovelace avatar Robinlovelace commented on July 22, 2024

Yes, this is due to the fixed height of the map. I was just wondering if this can be fixed or if it's a bug - what are your views @usr110 ? I'm not sure how to set it as a relative height - I tried in the past and it failed, hence the possibility that it may be a bug. Thanks.

from pct-shiny.

nikolai-b avatar nikolai-b commented on July 22, 2024

p.s. the R shiny browser doesn't handle this on my PC but it works in FF and Chrome.

from pct-shiny.

usr110 avatar usr110 commented on July 22, 2024

@nikolai-b Brilliant work once again!
For me it seems to be working both in the Shiny Browser as well as in FF. Looks magnificent now. Great!

The only thing which got messed up is DataTables - they aren't working any more. Of course it's not relevant to this commit, but relates to the version of leaflet. Shiny advises us to move from Shiny:Rendertable to DT::Rendertable.

from pct-shiny.

Robinlovelace avatar Robinlovelace commented on July 22, 2024

These are big steps forward. Thanks for the fix and comments.

from pct-shiny.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.