Comments (5)
Ooh! That's not good.
The generated SQL should put double quotes around column names.
This should be an easy fix (the helpers here: https://github.com/Nozbe/WatermelonDB/tree/master/src/adapters/sqlite )
I'll try to write up a basic Contributing.md guide with the how to for running tests and whatnot tomorrow, and maybe you'd like to take a stab at fixing it?
from watermelondb.
Sure - just ping me here as soon as the guide is up and I'll give it a shot.
from watermelondb.
@sebastian-schlecht OK, check out:
https://github.com/Nozbe/WatermelonDB/blob/master/CONTRIBUTING.md
And let me know if you run into any issues
from watermelondb.
@radex started working on this - changing encodeSchema
seems to be insufficient. Shouldn't also insert, update and query operations escape column (& table) names in order to be safe?
https://www.sqlite.org/lang_keywords.html
Querybuilders like knex, use a similar pattern.
from watermelondb.
Shouldn't also insert, update and query operations escape column (& table) names in order to be safe?
Yep, exactly!
from watermelondb.
Related Issues (20)
- Error: no such function: json_extract (code 1 SQLITE_ERROR) - Only in android - ios Working fine HOT 2
- Pass props from screen to withObservables HOT 1
- Database inspector on Android and react native 0.73
- Bridgeless Mode support (New Architecture) [0.74] HOT 3
- Recommended workflow for database migrations on live iOS app? HOT 1
- Migration not running in Release APK, resetting the database
- App should not hold onto subscriptions or Watermelon objects while resetting database.
- Problems with memory and app lock
- web demo link is broken
- Cannot access property from database response
- I will like to know if watermelonDB is perfect to our NodeJS project HOT 1
- Relations using custom key HOT 1
- Not able to see database in Flipper - react native
- Raw queries support? HOT 3
- Sync feature not working question HOT 1
- Support for numeric ids HOT 2
- implement makeColumnOptional function HOT 1
- TypeError: Cannot read property 'type' of undefined
- Failed to load better_sqlite3.node module with WatermelonDB on React Native
- ERROR TypeError: Cannot read property 'initializeJSI' of null, js engine: hermes HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from watermelondb.