nov1n / kubernetes-workflow Goto Github PK

Kijken of travis failed als godep go build failed.

Fix code coverage to include all files, not only the files that were touched in a test.

When the thirdparty endpoint does not exist we get the error below, when however we create it we keep getting the error even though the endpoint is reachable now

E0527 10:11:57.013233 7389 reflector.go:216] github.com/nov1n/kubernetes-workflow/pkg/workflow/manager.go:172: Failed to lis│
t *api.Workflow: could not reach http:/127.0.0.1:8080/apis/nerdalize.com/v1alpha1/workflows: Get http:///127.0.0.1:8080/apis/ne│
rdalize.com/v1alpha1/workflows: http: no Host in request URL

Fix deepEquals in https://github.com/nov1n/kubernetes-workflow/pull/12/files#r63482063.
It should compare the expected struct with the resulting struct and give appropriate errors when they mismatch.

• Rename WorkflowManager to Manager
• Rename wc to m in NewWorkflowManager
• Rename w varaible to m in WorkflowManager methods
• Create a workflow_utils and move function IsWorkflowFinished to there as with job_utils

We should find out why updateFunc is called so often, while no wfs are updated. See https://github.com/nov1n/kubernetes-workflow/pull/12/files#r63482594.

List en Watch logic staat nu nog in client/workflows.go, moet naar client/thirdparty.go

EnqueueAfter is blocking atm to make sure no parallel tracks occur.
We should make it non-blocking, but for that a custom workqueue is needed.

This looks like a compelling concept, but hasn't been changed in a while.

Is there any ongoing development / running workloads on this?

syncWorkflow retruns nil in almost every case.
We should check what to do:

• return error?
• return list of errors?
• don't return and log all errors

Workflow Client should do better error handling in case:

• the API server goes down
• the API server returns unexpected output

Version nerdalize.com/v1alpha1 should not be hardcoded in source.
We should be able to update to another version without having to replace all instances in code.

transitioner / manage workflow are on dirrerent levels of abstraction, think about responsibilities of manager and transitioner