Comments (14)
@guastallaigor that turns out to be true, when I used lower-case letters it worked, but that's not how I expect it to work, and that's why I opened this issue 👍
from nes.css.
All of the commitlint
settings we're using are based on the Angular Commit Conventions. Please read through those. I've been using these conventions in a great many projects to date. There are several substantial benefits that come from them, but here are the biggest ones:
-
Commits are easy to read
Reviewing PRs is often one of the most time consuming parts of running an open source project. Forcing commits into a standard format makes reviewing PRs much faster, and it makes determining the value of a commit much easier. -
Changelogs can be generated automatically
Check out this changelog example. By using properly formatted commit messages, we can generate changelogs automatically that are actually useful to us.
Now, I will say that the sentence-case
rule on commit subjects regularly trips me up as well. I'm not opposed to the idea of switching that rule off so that commit titles can start with uppercase characters and end with a dot (.) if the rest of the team wants to do that. I'm also curious about @BcRikko's thoughts with all of these changes so far.
from nes.css.
Hello @4k1k0, as up to this moment all messages must be like this type: msg
.
No dot at the end of the line.
Only lower-case letters.
Example: feat: add new feature
or feat(icons): add new icon
You can also use npm run commit
that can help you with that
But some things will be changed to make this rules more loose.
from nes.css.
Thank you so much! It worked like a charm.
from nes.css.
@4k1k0 @guastallaigor actually I merged #144
Upper-case letters are ok now, as well as a dot at the end of a sentence :)
from nes.css.
More on this, still trying to commit
git ci -am "feat(testing): Merge Develop and add Storybook and Backstopjs tests" --no-verify
git ci -am "feat(test): Merge Develop and add Storybook and Backstopjs tests" --no-verify
git ci -am "feat(test): Merged Develop and add Storybook and Backstopjs tests" --no-verify
git ci -am "feat(test): Merged Develop and added Storybook and Backstopjs tests" --no-verify
git ci -am "feat(test) Merged Develop and added Storybook and Backstopjs tests" --no-verify
Errors I get are
✖ message may not be empty [subject-empty]
✖ type may not be empty [type-empty]
✖ subject must not be sentence-case, start-case, pascal-case, upper-case [subject-case]
What is the subject anyway?
My point is: this just doesn't feel natural, and its very annoying
from nes.css.
How about making this loose rule? 🤔
This rule is used in vuejs project.
https://github.com/vuejs/vue/blob/dev/scripts/verify-commit-msg.js
@trezy What do you think? 🤔
from nes.css.
More on this, still trying to commit
git ci -am "feat(testing): Merge Develop and add Storybook and Backstopjs tests" --no-verify git ci -am "feat(test): Merge Develop and add Storybook and Backstopjs tests" --no-verify git ci -am "feat(test): Merged Develop and add Storybook and Backstopjs tests" --no-verify git ci -am "feat(test): Merged Develop and added Storybook and Backstopjs tests" --no-verify git ci -am "feat(test) Merged Develop and added Storybook and Backstopjs tests" --no-verify
Errors I get are
✖ message may not be empty [subject-empty] ✖ type may not be empty [type-empty] ✖ subject must not be sentence-case, start-case, pascal-case, upper-case [subject-case]
What is the subject anyway?
My point is: this just doesn't feel natural, and its very annoying
I don't think you can use upper-case letters anywhere in the commit.
Have you tried this?
feat(test): merged develop and added storybook and backstopjs tests
from nes.css.
@evexoio Yes I understand, I'm used to commit using upper-case letters aswell, but in this repo I'm trying to get used to commiting using only lower-case letters.
from nes.css.
More to this, if you end your commit message with a dot it'll get rejected as well 🤧
from nes.css.
Commits are easy to read
Agreed, I can see that already. and we can keep that the way it is with a less strict rule to achieve balance between commit message's clarity and the ease of actually commiting.
@trezy can we apply the changes you and @BcRikko suggested please?
from nes.css.
@evexoio Absolutely! I’ll take a look at that tomorrow. I’m hosting a big holiday party today.
If anybody wants to look into it sooner, you’ll want to look into commit-lint
rules to implement the changes to the subject format, and cz-customizable
to alter the available commit types.
from nes.css.
Please, could someone explain me how to make a commit from the command line?
This is what I'm doing:
- Clone my fork
- Change to develop branch
- Make some changes
- Create a new branch
- Adding the modified files to the stage
- Commit
I've trying to do it since this morning but I don't understand husky. According to the docs git commit -m 'Message'
should do the job, but I keep getting this error message:
✖ message may not be empty [subject-empty]
✖ type may not be empty [type-empty]
✖ found 2 problems, 0 warnings
What I am doing wrong? 😟
🙇♂️ 🙏
from nes.css.
🎉 This issue has been resolved in version 1.0.0 🎉
The release is available on:
Your semantic-release bot 📦🚀
from nes.css.
Related Issues (20)
- favicon etc are SNES not NES controllers? HOT 1
- about polyfill
- Package engine "Node >= 10.0.0" causing installation problem in Node 15.4.0 HOT 4
- Simple cool improvements for the project! HOT 1
- Visual glitch in non-rounded dark dialog HOT 1
- Form component disable style HOT 1
- Custom theme HOT 1
- radio
- NES.css react component library HOT 3
- Adding Korean translation of CONTRIBUTING.md HOT 4
- `package.json`'s `engines` field having `"Node >= 10.0.0"` prevents installation with Node 16.9.1 HOT 4
- Buttons on index.html aren't clickable
- It's look like different between chrome and debug tools.What happened?
- Adding Discord Icon HOT 4
- Adding font for Arabic HOT 1
- Change icon HOT 1
- Feat: Update Twitter icon
- Buttons and containers look .. weird on Firefox and Chrome HOT 1
- I
- G
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nes.css.