Coder Social home page Coder Social logo

Comments (8)

asgvard avatar asgvard commented on June 10, 2024 1

Hi,

Please provide debug info about siblings sorted so we can inspect their coordinates.
The algorithm is quite straightforward, it sorts based on main axis first, then by the secondary axis. It is also possible that your elements overlap with each other.
So far it is quite hard to understand the problem since it works fine in all our apps, as well as the sandbox App.js and App example with boxes with random coordinates.

from react-spatial-navigation.

MarcoFiusco avatar MarcoFiusco commented on June 10, 2024

After some debugging sessions, I found out that the problem is caused by the function sortSiblingsByPriority.
When I press RIGHT, the array which comes out from this function is sorted wrongly in some cases:
the element which is really at the right of the current focused element, is not the 1st.
Thanks
Marco

from react-spatial-navigation.

rroslaniec avatar rroslaniec commented on June 10, 2024

I found same problem. Create for example FlatList. Then when Element is focused I added transform: scale(1.2). Elements in that scenario are overlapping to each other and this bug occurs. @asgvard

from react-spatial-navigation.

asgvard avatar asgvard commented on June 10, 2024

Hi.

Scaling of the element does not change its "real" size or position, it should not impact the logic of the calculation of coordinates. When you use translateX or translateY - it also doesn't impact real coordinates. With the FlatList though - I would assume you have a different issue. FlatList wraps each item into another View (or React.Fragment, I don't remember). And this extra layer of the wrapper might break the calculation of the coordinates for each item. Please try to use "debug: true" mode and see the output of which children elements are suggested to get the next focus and which coordinates do they have.

from react-spatial-navigation.

rroslaniec avatar rroslaniec commented on June 10, 2024

@asgvard
item-18 is missing in calculations:
Zrzut ekranu 2020-11-12 o 12 53 06
Zrzut ekranu 2020-11-12 o 12 52 51

from react-spatial-navigation.

rroslaniec avatar rroslaniec commented on June 10, 2024

Also - each element have margin-left - maybe that is the case?

from react-spatial-navigation.

asgvard avatar asgvard commented on June 10, 2024

Is this happening after the lazy rendering of the new FlatList items? E.g. after you scrolled far enough past the initial visible chunk of the FlatList? I remember we had similar issues when we tried to use FlatList, and it was due to it creating and removing items on the fly. So it could be that the "old" items having their coordinates to be obsolete at the time when it adds or removed new items during scrolling. First I would try to remove scaling and any other extra styles that could affect this and see how it works then to isolate the issue. Also I would try to go right and then left again and see if it skips this specific item consistently. In the other words, is this behavior occurs only for some specific item, or it's just "random" every time? For now it's hard to say since I can't see every sibling element coordinates.

from react-spatial-navigation.

rroslaniec avatar rroslaniec commented on June 10, 2024

Ok, I found problem my problem - margin-left was passed to too deep element.

from react-spatial-navigation.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.