Comments (8)
@salvan13 Perhaps navigateByDirection
is a good name. Because "navigateTo" might mean "navigate to some place" instead of direction. Also "focusNext" might mean it focuses some component.
@alfimois I'll add some comments to PR in a minute
from react-spatial-navigation.
Usually mouse wheel doesn't change focus on elements, not sure if we should add this. Can you explain your use case step by step?
Our TVs can change focusing by a wheel on the remote ;)
from react-spatial-navigation.
Hi @alfimois
Usually mouse wheel doesn't change focus on elements, not sure if we should add this. Can you explain your use case step by step?
from react-spatial-navigation.
Added by that PR #36
from react-spatial-navigation.
Thanks!
So basically you need a method for navigate in a certain direction programmatically. Right?
In this case I would call it navigateTo(direction)
or focusNext(direction)
instead of smartNavigateByDirection(direction)
(since smartNavigate is not used in the public api).
what do you think @asgvard ?
from react-spatial-navigation.
@alfimois also please when you open a pull request don't mix things: like refactoring + new feature.
Let's keep pull request minimal and focus on one thing.
Thanks!
from react-spatial-navigation.
Let's keep pull request minimal and focus on one thing.
@salvan13 OK, sry)
from react-spatial-navigation.
Added #36
from react-spatial-navigation.
Related Issues (20)
- CSS gap:0 breaks navigation HOT 1
- Focus lost when Item Removed HOT 4
- Sometimes navigation doesn't work after go back to previous screen HOT 1
- a vulnerability CVE-2020-15168 is introduced in @noriginmedia/react-spatial-navigation HOT 2
- Focuses the second item in the list, after navigating from the fixed menu HOT 2
- Performance/Crash issue when load multiple rails and hold arrow keys to navigate HOT 1
- [Question]Can I use this package in a ReactJS project? HOT 4
- Focusable items hidden are able to be accessed. HOT 19
- withFocusable usage with forwardRef HOT 9
- Understanding of roadmap for library HOT 5
- more than 100 UI elements in funcational component taking too long to navigate. HOT 1
- 2-Directional Grid-type Items HOT 1
- display none control HOT 2
- Focus gets lost in case of collision HOT 3
- Track Child not recognizing children
- RTL is not supported
- Loss of focus when a component is rendered HOT 2
- Error when Server Side Rendering HOT 1
- Focusable elements not recognised when layout is position absolute HOT 5
- How should I handle focus when opening/closing a pop-up? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-spatial-navigation.