Coder Social home page Coder Social logo

Comments (8)

asgvard avatar asgvard commented on June 2, 2024 1

@salvan13 Perhaps navigateByDirection is a good name. Because "navigateTo" might mean "navigate to some place" instead of direction. Also "focusNext" might mean it focuses some component.
@alfimois I'll add some comments to PR in a minute

from react-spatial-navigation.

yarikleto avatar yarikleto commented on June 2, 2024 1

Usually mouse wheel doesn't change focus on elements, not sure if we should add this. Can you explain your use case step by step?

Our TVs can change focusing by a wheel on the remote ;)

from react-spatial-navigation.

salvan13 avatar salvan13 commented on June 2, 2024

Hi @alfimois
Usually mouse wheel doesn't change focus on elements, not sure if we should add this. Can you explain your use case step by step?

from react-spatial-navigation.

yarikleto avatar yarikleto commented on June 2, 2024

Added by that PR #36

from react-spatial-navigation.

salvan13 avatar salvan13 commented on June 2, 2024

Thanks!
So basically you need a method for navigate in a certain direction programmatically. Right?

In this case I would call it navigateTo(direction) or focusNext(direction) instead of smartNavigateByDirection(direction) (since smartNavigate is not used in the public api).

what do you think @asgvard ?

from react-spatial-navigation.

salvan13 avatar salvan13 commented on June 2, 2024

@alfimois also please when you open a pull request don't mix things: like refactoring + new feature.
Let's keep pull request minimal and focus on one thing.
Thanks!

from react-spatial-navigation.

yarikleto avatar yarikleto commented on June 2, 2024

Let's keep pull request minimal and focus on one thing.
@salvan13 OK, sry)

from react-spatial-navigation.

yarikleto avatar yarikleto commented on June 2, 2024

Added #36

from react-spatial-navigation.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.