Comments (8)
@miketheodorou: Hello again! Busy weeks right now, but we've added a task to look into this issue and will be starting on it hopefully soon; Just so you know there's some activity on this topic.
from norigin-spatial-navigation.
Status Update:
The pull request #105 has been approved. It will be incorporated into the upcoming release, effectively addressing the associated issue.
from norigin-spatial-navigation.
Hey @predikament, I created a small POC to demonstrate the issues that I am having.
When I initialize the library with the following invocation, the onClick
handlers on the buttons, as well as the native behavior for the Link
component from react-router-dom
no longer work when pressing the Enter
key. I'm able to get the onKeyUp
event to fire on one of the buttons, so it's not all events that are blocked, but the onClick
is pretty important to keep enabled when we're actually focusing the DOM nodes.
init({ shouldFocusDOMNode: true });
I would prefer to not have to pass onEnterPress
to the useFocusable
options when shouldFocusDOMNode
is enabled because it's breaking the base behavior of these elements onClick
methods.
I would expect the behavior to work the way it does when you comment out the init
invocation on line 8 of main.tsx
and instead use Tab
to move through the elements and press Enter
to trigger the onClick
handlers as well as the default navigation behavior.
Basically, I would like the library to move through the elements with the same logic it does, but not disable the onClick
behavior.
Here are a couple videos as well that outline what I am describing.
With init
invocation
https://github.com/NoriginMedia/Norigin-Spatial-Navigation/assets/22715776/0c2b76ad-3d64-4c2f-b1e2-ac40c6e418f1
Without init
invocation
https://github.com/NoriginMedia/Norigin-Spatial-Navigation/assets/22715776/d7ce1f38-35a1-406c-87bd-fd2c88794a6b
from norigin-spatial-navigation.
@Braggiouy Thank you! Very excited to try this out. I appreciate you all adding this.
from norigin-spatial-navigation.
Thanks for the response @predikament! I'll get a little POC built and sent over to you when I get some free time.
from norigin-spatial-navigation.
Hey Norigin Media Team, just following up on this to see if you have any thoughts or recommendations.
Thanks!
from norigin-spatial-navigation.
Hello @miketheodorou!
Could you give a simple usage example based on your request here?
We've implemented a lot of accessibility related stuff and have not seen this need ourselves, so an example would help to better understand.
Thanks in advance.
from norigin-spatial-navigation.
@miketheodorou: Thanks for the POC and the videos!
We'll have a look.
(@asgvard: ⬆️)
from norigin-spatial-navigation.
Related Issues (20)
- Add a function to set key events HOT 2
- Migration from "styled-components" to "linaria" HOT 1
- using stack navigatior not able to find the focus in react-native-web. HOT 7
- Focus is not Working properly when Stack navigation is Added HOT 1
- The focus is not reaching the intended destination. HOT 6
- Throws error on newest version of lg web os HOT 2
- Test cases HOT 6
- React Native, cannot connect native focus to Norigin focus HOT 2
- Compatibility with WebView in AndroidTV HOT 1
- Can anyone check why manual setFocus not working as expected HOT 2
- RTL Flag isn't work HOT 1
- ScrollTo is not Working in Y - axis When Data is Wrapped inside the Row HOT 1
- Allow `ref` on items not yet displayed. (see below for more info)
- Allow for `onArrowPress` to have next focused node as property of KeyPressDetails HOT 1
- Unexplainable behaviour when focusable is removed
- Dynamic RTL switching
- A suggestion about keycode mapping HOT 2
- focus on closest element within the directional input? HOT 2
- Vertically stacked items focus issue HOT 1
- How to deal with conditional rendering of a FocusContext HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from norigin-spatial-navigation.