Coder Social home page Coder Social logo

Comments (8)

predikament avatar predikament commented on May 24, 2024 4

@miketheodorou: Hello again! Busy weeks right now, but we've added a task to look into this issue and will be starting on it hopefully soon; Just so you know there's some activity on this topic.

from norigin-spatial-navigation.

Braggiouy avatar Braggiouy commented on May 24, 2024 3

Status Update:

The pull request #105 has been approved. It will be incorporated into the upcoming release, effectively addressing the associated issue.

from norigin-spatial-navigation.

miketheodorou avatar miketheodorou commented on May 24, 2024 2

Hey @predikament, I created a small POC to demonstrate the issues that I am having.

When I initialize the library with the following invocation, the onClick handlers on the buttons, as well as the native behavior for the Link component from react-router-dom no longer work when pressing the Enter key. I'm able to get the onKeyUp event to fire on one of the buttons, so it's not all events that are blocked, but the onClick is pretty important to keep enabled when we're actually focusing the DOM nodes.

init({ shouldFocusDOMNode: true });

I would prefer to not have to pass onEnterPress to the useFocusable options when shouldFocusDOMNode is enabled because it's breaking the base behavior of these elements onClick methods.

I would expect the behavior to work the way it does when you comment out the init invocation on line 8 of main.tsx and instead use Tab to move through the elements and press Enter to trigger the onClick handlers as well as the default navigation behavior.

Basically, I would like the library to move through the elements with the same logic it does, but not disable the onClick behavior.

Here are a couple videos as well that outline what I am describing.

With init invocation
https://github.com/NoriginMedia/Norigin-Spatial-Navigation/assets/22715776/0c2b76ad-3d64-4c2f-b1e2-ac40c6e418f1

Without init invocation
https://github.com/NoriginMedia/Norigin-Spatial-Navigation/assets/22715776/d7ce1f38-35a1-406c-87bd-fd2c88794a6b

from norigin-spatial-navigation.

miketheodorou avatar miketheodorou commented on May 24, 2024 2

@Braggiouy Thank you! Very excited to try this out. I appreciate you all adding this.

from norigin-spatial-navigation.

miketheodorou avatar miketheodorou commented on May 24, 2024 1

Thanks for the response @predikament! I'll get a little POC built and sent over to you when I get some free time.

from norigin-spatial-navigation.

miketheodorou avatar miketheodorou commented on May 24, 2024

Hey Norigin Media Team, just following up on this to see if you have any thoughts or recommendations.

Thanks!

from norigin-spatial-navigation.

predikament avatar predikament commented on May 24, 2024

Hello @miketheodorou!

Could you give a simple usage example based on your request here?

We've implemented a lot of accessibility related stuff and have not seen this need ourselves, so an example would help to better understand.

Thanks in advance.

from norigin-spatial-navigation.

predikament avatar predikament commented on May 24, 2024

@miketheodorou: Thanks for the POC and the videos!

We'll have a look.

(@asgvard: ⬆️)

from norigin-spatial-navigation.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.