Not as optimized for Webpack as it could be about optimize-js

[nolanlawson]

Example input and output: https://gist.github.com/vigneshshanmugam/89867ac713d1160c865c53c93e47470a

[ggoodman]

For science: https://gist.github.com/ggoodman/72c4366ebe9bee47ad158527ee4c5e93

[TheLarkInn]

Did we test these w/ the V8LazyParseWebpackPlugin?

[ggoodman]

@TheLarkInn if I had some guidance on moving to Webpack 2, I would try it out.

[TheLarkInn]

That plugin may work with webpack 1 also, but what specifically do you need help with for webpack 2.

[nolanlawson]

This may be a good first patch, given that you basically just need to add a new test case (input.js and output.js) and then add a new condition to check if the function is inside an array inside of a call expression. ASTExplorer is very helpful here.

[vigneshshanmugam]

@TheLarkInn Does lazyparseplugin adds the parans for the modules in array?

[TheLarkInn]

It sure does!! If you have a large app feel free to try it. Only catch is that I believe you have to tell UglifyJsPlugin compress option to set negate_iife: false.

[TheLarkInn]

@vigneshshanmugam if you have an app that we can test with I'd be interested to see the statistics.

[vigneshshanmugam]

@TheLarkInn I tried it and updated the gist. It fails to wrap the inner functions as well.

Also updated the readme here - TheLarkInn/LazyParseWebpackPlugin#4

[TheLarkInn]

Awesome!!! I intentionally didn't wrap the inner functions inside modules because I wasn't sure the benefit, but it's definitely possible to use a webpack parser plugin to do this.

[vigneshshanmugam]

Ahh got it.. But i believe the benchmarks in the README includes the wrapping for inner functions as well.. Anyways as you said, its possible to do this :)

[nolanlawson]

Fixed in #33