Add support for npm github: dependency resolver. about scanner

[mbalabash]

Hey @fraxken
Yes, I think you are right.
I tried npx pacote tarball github://github.com/mbalabash/estimo.git#v2.3.0 ./estimo-v2.3.0.tgz) and looks like it works well. I can try to prepare PR for it.

Am I right that we need to:

1. change mergeDependencies.js to add dependency links with github: to customResolvers
2. change depWalker.js to make it process github: links in the same way how it works now for git+ links

?

[fraxken]

@mbalabash Yes that's right.

However i think mergeDependencies already add github: because of the RegEx (to confirm). However yes the walker was only designed for git+ what is not great in the light of what is possible.

I also wonder if i missed a case with git: (because i'v seen an example in the npm doc).

https://docs.npmjs.com/cli/v8/configuring-npm/package-json#dependencies

[fraxken]

Note: UT are not very good around walker (and i have few cross-os issues to fix).

Also, think to setup an env NODE_SECURE_TOKEN with an npm access token (Otherwise you will be limited on the use of the npm registry).

https://docs.npmjs.com/creating-and-viewing-access-tokens

[mbalabash]

Yes, mergeDependencies.js already will add github: and git: links. I misread RegEx 😁
OK, then I will start working on PR. Probably will ask some more questions)

[mbalabash]

Opened PR

[fraxken]

Thanks for the contribution @mbalabash.

[fraxken]

@all-contributors please add @mbalabash for code

[allcontributors]

@fraxken

I've put up a pull request to add @mbalabash! 🎉