Comments (4)
Oh, man, I really wanted to comment on this last night, but ran out of steam before I got to it.
This issue is near and dear to my ❤️. I tried to get a read on how to effectively go about this over here: nodebugme/discussion#5.
The biggest help would be to compile a list of these PRs with the following information:
- Does the PR actually address what it intends to address?
- Is the PR already addressed by subsequent commits?
- Did someone known to work on core bless the PR, or is it still up for debate?
- How much work (in hours) do you estimate are left on the PR, taking into account pending comments, the PR applying cleanly, etc. Unresolved design issues are the most costly in terms of time, then applying the PR, then style comments, in descending order.
The more eyes, the better. Once we've got a good read on how long a given PR will take to merge, we can make a decision about whether it's better to take it to the finish line or to close it as abandoned (apologetically!) Ideally these would be fulfilled against joyent/node and then iojs can cherry-pick the resulting commits.
The other half of this is to make sure that iojs' tracker never gets to that point, and that discussion is happening over here.
from node.
Concerns about this have been a source of discussion for some time, since the Node Forward work started actually. I'll try to distill down the main talking points:
- Effort should be spent first and foremost responding to PR's made against the new repo. We have a chance here not to burn contributors who had given up on joyent/node but that requires that we do a much better job here.
- It might be better to ask someone to re-submit the PR themselves than do the work of porting it and opening it ourselves. Walking through the process of re-engaging and seeing the difference in response is something that could help them stick with the project and continue to engage.
- If there are great PR's where the author is not interested in re-submitting themselves then, at some point, we should just pull them in ourselves.
Hope that helps :)
from node.
There are some good typo-fixing/doc-improving PRs in that stash. Should I start asking them to re-submit the PR to io.js?
from node.
@a0viedo I would start by asking if they'd like someone to adopt their PR, or if they're still interested in maintaining that PR themselves, and cc'ing me on the issue. I can review/shepherd in the commit into node and iojs from there.
from node.
Related Issues (20)
- [invalid defect] Cannot exit all the processes when `CTRL + C` in readline HOT 4
- Provide some mechanism to conditionally and synchronously import modules (or just builtins) from ESM HOT 8
- v8::internal::TranslatedState::CreateNextTranslatedValue(int, v8::internal::TranslationArrayIterator*, v8::internal::DeoptimizationLiteralArray, unsigned long, v8::internal::RegisterValues*, _IO_FILE*) [/var/lang/bin/node] HOT 3
- Not possible to know when fs.watch has started on macOS
- VM Context doesn't reflect root-level variable declarations HOT 1
- Segfault on non-x86_64 architectures
- Comment field on `crypto.generateKeyPair` HOT 2
- WASI stdio (stdin, stdout) API not very useful HOT 4
- Wrong gpg key in docs HOT 2
- stream pipeline kills process when writeStream is closed HOT 2
- npm not running
- test-error-serdes times out HOT 9
- ContextifyContext::PropertyDefinerCallback() never intercepts the request
- Node
- test: parallel/test-fs-watch-recursive-delete fails on IBM i HOT 1
- http: keepalive race condition near timeout HOT 9
- @nodejs/crypto HOT 2
- Node crashes on large number of SharedArrayBuffer
- V8 CI build error on ppc HOT 5
- Add support for subresource integrity in imported module scripts HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node.