Comments (13)
Good idea, +1
from node.
This would be a good addition and make it easier for a new contributor to help out. 👍
from node.
👍 I think that would be helpful for maintainers, contributors, and users (who watch PRs that they want/need)
from node.
I am not good at interacting with robots. Glad this is getting some traction, though!
from node.
+1 from me too.
As possible refinement, we could tag issues "bug fix", "api change" and "api addition". I think that's more clear for people who aren't thinking about semver all day long.
from node.
@piscisaureus a risk of not being explicit with semver-matching labels is someone making a mistake and not realizing that there is an implicit meaning. For example, api-change
doesn't always mean breaking.
from node.
Yeah, I'm wary of using non-semver terminology. major
means that there's an api change, and that api change is breaking. It's much more defined and explicit.
from node.
We should make this happen, it's going to be really hard to track which number we should bump for each release beyond 1.0.0, it would be nice to just search through PRs for these labels.
How about: semver-major
, semver-minor
, semver-patch
and every PR must be labelled with one of these, just like the commits have to have the additional metadata in them. The person responsible for a release can then go and hound mergers who haven't labelled PRs between releases.
from node.
👍 to semver-major
, semver-minor
, and semver-patch
from node.
It would be sort of neat if we could automate the addition of labels by running the tests from the tip of iojs against the PR tip -- if they pass, we can safely label it minor
or patch
. Otherwise, it's a major
bump.
For now I don't see any problem with collaborators adding these labels where appropriate, the above suggestion is strictly a "for the future" sort of thing :)
from node.
+1 on the general idea, but from what @chrisdickinson is saying, we'd have
to do it more reliably - a failed test could mean a major bump or just a
bad PR. However I think these tags would be really sweet for managing the
PRs.
A repository I think does a great job managing PRs and issues would be
TryGhost/Ghost, if anyone wants to take a look.
On Monday, January 12, 2015, Chris Dickinson [email protected]
wrote:
It would be sort of neat if we could automate the addition of labels by
running the tests from the tip of iojs against the PR tip -- if they pass,
we can safely label it minor or patch. Otherwise, it's a major bump.For now I don't see any problem with collaborators adding these labels
where appropriate, the above suggestion is strictly a "for the future" sort
of thing :)—
Reply to this email directly or view it on GitHub
#69 (comment).
from node.
We now have semver-minor
and semver-major
.
from node.
w00t! Thanks everyone.
from node.
Related Issues (20)
- test_runner (after) doesn't work on v21.7.0 HOT 1
- breaking change in 21.7.0 when mocking fetch HOT 4
- Enable --security-revert to be used in NODE_OPTIONS environment variable HOT 24
- Recursive fs.watch crashes on Linux when deleting files
- [feat] Provide a standard way to get global and `npx` temporary `node_modules`
- http: create response.overwriteHead() for things like stream piping error handling HOT 5
- Node.js must support Windows Server 2016 HOT 2
- The assertion module should signals failures through messages to the test runner
- parallel/test-domain-error-types is flaky HOT 1
- util.styleText(): Combining multiple styles in a single string? HOT 2
- mile
- Adding TCP_USER_TIMEOUT to "net"
- Node js tutorial
- Node test failing HOT 2
- dns.resolveTxt() with multiple strings HOT 1
- macOS: `fs.watch` does not report delete of watched folder HOT 3
- build: wasm-to-js-tq-csa.cc takes ages to compile HOT 6
- `node:test` hangs when `BroadcastChannel` is left open HOT 1
- ETIMEDOUT error when sending http request to some domains/subdomains HOT 1
- Document `highWaterMark` option of `events.on()`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node.