Comments (7)
I haven't looked at the code for the bot, but theoretically could we just replace the PR author setup with the first commit author?
I'm happy to take a look at it, but I'm not a CODEOWNER, just a triage member
@nodejs/github-bot
from node.
I think that's a limitation of the GitHub API – the alternatives/workaround are:
- land the PR with
commit-queue-rebase
Add this label to allow the Commit Queue to land a PR in several commits. (i.e. no purple merge) - land the PR manually
- add the original author as a co-author
I've been trying to do the latter when I notice the commit author is not the same person that sent the PR. I guess we could implement a check to refuse to land a PR when the author will be wrong.
from node.
I guess we could implement a check to refuse to land a PR when the author will be wrong.
That seems (IMO) a good solution, but I'm far from the person who would be affected by any of this
from node.
This changed recently, before when you added the "commit-queue-squash" it would squash on the first commit and keep the author of the first commit as the author of the landed commit.
Now the author of the pr becomes the author of the landed commit regardless if the first commit is theirs
from node.
I made a little experiment using the GH UI: targos#18, targos@adf6657
Squash and merge indeed changes the author (it doesn't let you keep it, you can only select the email address you want to be associated with the commit).
It adds a Co-authored-by:
field to the commit message, though.
from node.
This changed recently, before when you added the "commit-queue-squash" it would squash on the first commit and keep the author of the first commit as the author of the landed commit.
I think you're misremembering, AFAIK it's always been the case that GH uses the "PR opener" as commit author – and we're using the GH API since #40666.
from node.
This changed recently, before when you added the "commit-queue-squash" it would squash on the first commit and keep the author of the first commit as the author of the landed commit.
I think you're misremembering, AFAIK it's always been the case that GH uses the "PR opener" as commit author – and we're using the GH API since #40666.
I remember #45597 maybe it was landed with git node land
from node.
Related Issues (20)
- Inconsistent behavior with crypto.KeyObject.from() and key usage flags for RSA encryption/decryption HOT 1
- [Bug]: Vite Wallet does not run correctly after building it on Microsoft Windows. HOT 1
- Random wrong encoding of strings returned by .replace function HOT 1
- nodejs crashes at stream.c due to queue size assertion HOT 5
- Flaky text encoding regression in Node 22 HOT 1
- Reuse Blob Registry in Workers
- exec command 'playerctl status' does not work HOT 1
- test_runner: `latest.js` file is included by default HOT 1
- `cpSync` symlink handling regression HOT 3
- Node-API V8 Fast API HOT 2
- Nominating @abmusse to be a collaborator HOT 1
- Node 22.1+ crashes process when a lot of VM processes are created/destroyed in parallel workers HOT 6
- build warning with gcc 12 HOT 4
- Buffer to string conversion fails after a few KB of load. HOT 1
- Use the compilation cache when running typescript files through `--experimental-transform-types` HOT 5
- Encoding Issue with Special Characters in Node.js 22 Docker Image HOT 1
- `--experimental-test-coverage` falsely reports missing coverage where TS source is `import type` HOT 1
- BlueBot
- Bot oficial
- Bad error message in `--experimental-test-coverage` output when a source maps source module is missing HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node.