Coder Social home page Coder Social logo

Comments (8)

santigimeno avatar santigimeno commented on June 25, 2024 2

This is fixed in libuv, so it'll be fixed once a new version reaches node.

from node.

mcollina avatar mcollina commented on June 25, 2024 1

@santigimeno could you take a look?

from node.

targos avatar targos commented on June 25, 2024

@nodejs/libuv

from node.

Uzlopak avatar Uzlopak commented on June 25, 2024

@targos

Should I open another issue in libuv?

from node.

targos avatar targos commented on June 25, 2024

Maybe? I don't know if that would be relevant without a repro using libuv directly.

FWIW this commit changed the implementation of the uv_kill function on Windows: libuv/libuv@129362f

@vtjnash

from node.

santigimeno avatar santigimeno commented on June 25, 2024

So, I think there's a regression in libuv which might be solved in libuv/libuv#4341. Regardless, just curious why the need to call child.kill() in those tests as the child processes should exit gracefully.

from node.

Uzlopak avatar Uzlopak commented on June 25, 2024

@santigimeno

It spins up the server and then kills it. Was this way for quiete a while. i could have patched it, but then I could not have report this bug ;)

from node.

Uzlopak avatar Uzlopak commented on June 25, 2024

great job, thanks

from node.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.