Comments (8)
This is fixed in libuv, so it'll be fixed once a new version reaches node.
from node.
@santigimeno could you take a look?
from node.
@nodejs/libuv
from node.
Should I open another issue in libuv?
from node.
Maybe? I don't know if that would be relevant without a repro using libuv directly.
FWIW this commit changed the implementation of the uv_kill
function on Windows: libuv/libuv@129362f
from node.
So, I think there's a regression in libuv which might be solved in libuv/libuv#4341. Regardless, just curious why the need to call child.kill()
in those tests as the child processes should exit gracefully.
from node.
It spins up the server and then kills it. Was this way for quiete a while. i could have patched it, but then I could not have report this bug ;)
from node.
great job, thanks
from node.
Related Issues (20)
- `os.homedir()` on Windows returns non-existent path HOT 1
- shellJS.exec() or child_process.exec() not executing callback function HOT 6
- stream.compose(...) doesn't destroy all active composed streams when it is destroyed
- fs.createWriteStream can cause out-of-order writes, in v18.16+ HOT 3
- test_runner: t.after is never called HOT 9
- Snapshot run failed on special RegExp HOT 5
- Throws assertion with match delegation
- test_runner (after) doesn't work on v21.7.0 HOT 1
- breaking change in 21.7.0 when mocking fetch HOT 4
- Enable --security-revert to be used in NODE_OPTIONS environment variable HOT 27
- Recursive fs.watch crashes on Linux when deleting files HOT 6
- [feat] Provide a standard way to get global and `npx` temporary `node_modules` HOT 1
- http: create response.overwriteHead() for things like stream piping error handling HOT 5
- Node.js must support Windows Server 2016 HOT 2
- The assertion module should signals failures through messages to the test runner
- parallel/test-domain-error-types is flaky HOT 1
- util.styleText(): Combining multiple styles in a single string? HOT 4
- mile
- readFile in promises very slow
- Adding TCP_USER_TIMEOUT to "net"
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node.