Non-identifier exports not detected? about cjs-module-lexer

[evanw]

Wait, maybe it doesn't have anything to do with keywords. It looks like mapping to null works but mapping to 0 doesn't? Here are some tests with various expressions:

module.exports = {fi, if: 0}
{ exports: [ 'fi' ], reexports: [] }

module.exports = {fi, if: !0}
{ exports: [ 'fi' ], reexports: [] }

module.exports = {fi, if: -0}
{ exports: [ 'fi' ], reexports: [] }

module.exports = {fi, if: (true)}
{ exports: [ 'fi' ], reexports: [] }

module.exports = {fi, if: [true]}
{ exports: [ 'fi' ], reexports: [] }

module.exports = {fi, if: null}
{ exports: [ 'fi', 'if' ], reexports: [] }

module.exports = {fi, if: true}
{ exports: [ 'fi', 'if' ], reexports: [] }

I guess this is because the grammar is specified as (IDENTIFIER (`:` IDENTIFIER )?). Is there any reason to not support arbitrary expressions? Like module.exports = { version: '0.1.0' }.

I will use if: null for now.

[guybedford]

@evanw this is just a very simple lexer designed to be small and fast and it doesn't even have an expression parser. We could extend the grammar to support direct primitives in the object form, but for now I'm concerned that may be even more confusing too, it's not a clear line by any means yes. See also #6.

Supporting numbers and strings would be straightforward, I'm just not sure we want to push the blurry line in that direction here, would value your thoughts.

[guybedford]

The latest update has been upstreamed now, and the object form detection remains the same without string support. I'm open to further suggestions here, although the window is closing on the current set of updates. Closing for now but just let me know if we should reopen or make changes here further.

[evanw]

it doesn't even have an expression parser

Ah, this makes sense. I was mainly just surprised that support for this wasn't necessary to handle modules like that in the wild.

I recently shipped support for the 0 && module.exports = {...} pattern in esbuild btw. So far so good.