Update compiler on Linux s390x about build

[richardlau]

Another s390x gcc bug has been identified, this time in gcc 12 and 13 when c++20 is enabled:

• Bug 113960 - [11/12 Regression] std::map with std::vector as input overwrites itself with c++20, on s390x platform

This one currently doesn't affect Node.js because we haven't landed nodejs/node#45427. We are working with the RH team that looks after the gcc-toolsets to get the fix into gcc-toolsets (preferably 12) once upstream gcc have backported the fixes.

I'm about to open a PR to Ansible installation of gcc-toolsets 12 and 13 onto our RHEL 8 machines. This will make those compilers available on the machine so we can run test builds, etc. We can then make any required select-compiler.sh changes in a follow up PR.

[targos]

FWIW I'm always up for upgrading compilers anywhere 😄

[mhdawson]

@richardlau is the V8 code with the bug already in existing release lines or if not, likely to be backported ?

[richardlau]

@richardlau is the V8 code with the bug already in existing release lines or if not, likely to be backported ?

Current V8 in Node.js uses V8's custom optional. I don't know if the change will end up in the version of V8 we'll end up using in Node.js 22.

[mhdawson]

Ok so the question is if we need to have a new gcc for Node.js 22 or Node.js 23, right?

[mhdawson]

Thinking about it, we do often pull in a version of v8 after 22 is cut, so it may not be easy to know that until close to the LTS promotion.

It may be best to assume it will be needed for 22 so that we don't need to update compilers after 22 is cut.