Proposal: define libraries to include in qode.json about qode

[a7ul]

From what I understand you need a way to include dlls ?
Wont libraryPaths in the config work ?
https://github.com/nodegui/qode#configurations-available-from-qode-v103

[marcus-sa]

@master-atul thanks for pointing that out, I didn't even notice it at all.

Shouldn't the property just be called libraries instead of libraryPaths?
From the description Specify extra library paths to load dlls from, but in relative to what working directory exactly?

TL;DR

{
    'variables': {
        'qt_home_dir%': "/home/marcus-sa/Qt/5.13.1/gcc_64",
    },
    'target_conditions': [ 
        ['OS=="linux"', {
            'include_dirs': [
                '<(qt_home_dir)/include',
                '<(qt_home_dir)/include/QtTest',
                '<(qt_home_dir)/include/QtWidgets',
                '<(qt_home_dir)/include/QtCore',
            ],
            'libraries': [
            	'<(qt_home_dir)/lib/libQt5Test.so',
					^-- Being able to include libraries
						that comes with the Qt5 installation
                '<(qt_home_dir)/lib/libQt5Widgets.so',
                '<(qt_home_dir)/lib/libQt5Core.so',
            ],
        }],
    ],
}

[a7ul]

libraryPaths

The libraryPaths are relative to qode executable or (you can even provide absolute paths)

            'libraries': [
            	'<(qt_home_dir)/lib/libQt5Test.so',
					^-- Being able to include libraries
						that comes with the Qt5 installation
                '<(qt_home_dir)/lib/libQt5Widgets.so',

This should work aswell (if this config is from qode gyp)

[marcus-sa]

The problem is that Qode only copies the libraries that I just wrote (QtCore, QtWidgets, QtGui) instead of the entire framework with all of its different libraries.
Installing Qt locally on my machine, I can see that they have 20+ libraries you can include, but since Qode only copies 3 of them (the ones needed for NodeGUI) it's impossible to actually use Qode for building 3rd party "plugins" that depend on specific Qt libraries that comes with the default installation...

That config I provided is the one from my own repository.

I'll try to implement it and create a PR.

[a7ul]

Why will qode include libraries that it doesnt need ? @marcus-sa

Ideally qode shouldnt depend on QtWidgets aswell since it only needs QtGui( for QApplication) and QtCore.

All other libs are needed for Nodegui shared binary

I am planning to remove QtWidgets also from Qode.

[a7ul]

So in short it would be better if you could add the libraries you need to your own shared library that you are building (ng-test)