Coder Social home page Coder Social logo

Comments (4)

ploer avatar ploer commented on July 28, 2024

Hmm, interesting. I'll take a look at this, but might be a while before I get around to it (sounds like your workaround is sufficient for the moment).

from passport-saml.

brianhartsock avatar brianhartsock commented on July 28, 2024

@darrenmce Had the same issue. See node-saml/xml-crypto#59 where I'm trying to get a few changes into xml-crypto. Discussion is ongoing.

from passport-saml.

darrenmce avatar darrenmce commented on July 28, 2024

@brianhartsock ah, great to know its not just me. I took a look at that issue in xml-crypto, and though its not clear to me where the fix belongs its becoming clear to me that a fix is necessary:

response from Oracle:


OAM 11gR2 federation declares the Signature in the ancestor element of the Signature element.

example:

<samlp:Response xmlns:samlp="urn:oasis:names:tc:SAML:2.0:protocol" 
xmlns:dsig="http://www.w3.org/2000/09/xmldsig#" 
xmlns:enc="http://www.w3.org/2001/04/xmlenc#" 
xmlns:saml="urn:oasis:names:tc:SAML:2.0:assertion" 
xmlns:x500="urn:oasis:names:tc:SAML:2.0:profiles:attribute:X500" 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" 
Destination="http://jungle.uk.oracle.com:7699/fed/sp/authnResponse20" ID="id-9FTHLvhLNQQz5ZnlW-nPu5F9UTe-WemnRyTiv7Gf" IssueInstant="2015-06-22T10:48:27Z" Version="2.0"> 
<saml:Issuer Format="urn:oasis:names:tc:SAML:2.0:nameid-format:entity">http://darakna.uk.oracle.com:14100/oam/fed</saml:Issuer> 

This might be different to how OIF 11gR1 generates the SAML artifact, but it is complaint with XML standards.

Please see:
Applying Namespaces to Elements and Attributes
6.1 Namespace Scoping
http://www.w3.org/TR/xml-names11/#scoping-defaulting

The processing application should be XML compliant and resolve the dsig Signature namespace from the namespaces declared in the ancestor samlp:Response element. The namespaces declared in the ancestor samlp:Response element should be applied to all elements within that element, up to the samlp:Response/ end tag.


from passport-saml.

ploer avatar ploer commented on July 28, 2024

Looks like @brianhartsock 's PR on xmlcrypto got merged; passport-saml PR #104 will take advantage of the change.

from passport-saml.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.