Coder Social home page Coder Social logo

Comments (7)

dsschiramm avatar dsschiramm commented on July 29, 2024 2

I'll start with this issue ok?
Seems like a good start for me (first time in a project doing something in an opensource project)

from node-oauth2-server.

jankapunkt avatar jankapunkt commented on July 29, 2024 1

Since #58 is merged I could start working on this on a new branch

from node-oauth2-server.

HappyZombies avatar HappyZombies commented on July 29, 2024

Wouldn't this require to change these functions to be class AuthorizationCodeGrantType extends AbstractGrantType?

from node-oauth2-server.

jwerre avatar jwerre commented on July 29, 2024

Yes.

from node-oauth2-server.

Uzlopak avatar Uzlopak commented on July 29, 2024

Try out https://lebab.unibtc.me/editor

from node-oauth2-server.

dsschiramm avatar dsschiramm commented on July 29, 2024

Should I change the way the import is written as well?

Example:
const AbstractGrantType = require('./abstract-grant-type');
To
import AbstractGrantType from './abstract-grant-type';

Or should I leave this change for another issue/pull request?

from node-oauth2-server.

Uzlopak avatar Uzlopak commented on July 29, 2024

Dont change, as it would just open the whole can of worms of esModule imports potentially breaking while running on node because of some reasons.

from node-oauth2-server.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.