Coder Social home page Coder Social logo

Comments (6)

nobitagit avatar nobitagit commented on June 15, 2024

Went through the article but I might be missing the real advantage of doing this. I don't understand what is the real difference in the output as in both cases it seems to me that the final css wouldn't be any different. Isn't it?

from material-floating-button.

mwinandy avatar mwinandy commented on June 15, 2024

The difference is on var surcharging from a parent scss file, because when I use mfb as bower component, I import the SCSS file from bower_components, and I won't modify or duplicate source SCSS, because it breaks during bower install.

Example: To change the value of $main-color (#E40A5D as default), I must redefine the value in _customize.scss with your technique. But as bower components, it will be not clean against bower install/update.

If you add !default at the end of variable def, you can override $main-color value in parent scss without change source file, if you define a value for $main-color before @import "./bower_components/mfb.scss". It's cleaner than actual.

@nobitagit to answer, there is no output differencies but there are in the dependencies's maintenability

from material-floating-button.

nobitagit avatar nobitagit commented on June 15, 2024

Still not really getting it but it may be just because i've just never used that technique. Care/time to make a pull request for this?

from material-floating-button.

cmfcmf avatar cmfcmf commented on June 15, 2024

I'd really like this to happen 👍

from material-floating-button.

nobitagit avatar nobitagit commented on June 15, 2024

Merged the PR, will make a new npm release as soon as possible.

ps - (unrelated to this issue) @cmfcmf as you are among the contributors let me know if you'd like to have your name and/or email added to the contributors list of this repo or just edit the package.json and make a quick PR for this, as you like.

from material-floating-button.

cmfcmf avatar cmfcmf commented on June 15, 2024

@nobitagit Done, please see #10.

from material-floating-button.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.