Comments (13)
I'm preparing a test to check this and there seems to be a problem indeed; Grid::delete_bins
seems to have no effect.
from pineappl.
Commit 46f3e5f adds a method Grid::delete_bins
which does what is needed at a very basic level. We still need:
- Python bindings and
- a CLI subcommand (possibly after merging #95)
- testing and unit tests.
from pineappl.
Python bindings provided in cd7bbaf
It builds, but I had some difficulties to test it. I tried in the interpreter, but it seems not to change the grid...
from pineappl.
Commit fccd890 fixes the problem, and commit 191f62c makes sure it stays fixed. However, the current implementation has the limitation that only bins from the left and/or from the right can be removed. Is that a problem for our purposes?
from pineappl.
Commit 5e629bf fixes yet another bug and commit aeddd4f adds the CLI.
from pineappl.
However, the current implementation has the limitation that only bins from the left and/or from the right can be removed. Is that a problem for our purposes?
I'm not sure to have understood what the limitation consists of...
Can you make an example of something I can't do?
from pineappl.
Say you have 10 bins you can't delete 3 and 4, for instance, because they are neither at the left (first bin would be 0) nor are they at the right (last bin would be 9). You could, however, delete bin 3 and 4 if you'd also delete 0, 1 and 2 at the same time, or alternatively if you'd delete 5, 6, 7, 8 and 9.
from pineappl.
Ok, now I understand, and it might be a limitation in general, but (if I remember correctly) the filters in apfelcomb.db
should be all at the beginning.
In any case, we'll raise a dedicated issue if and only if we find something for which is needed. For the time being it is perfect as it is.
(I was confused by the words left and right, since each bin has a left end and a right end, but now I perfectly understand)
from pineappl.
I was bit imprecise, so thanks for asking for a clarification! I agree with your proposal to open a separate Issue when this becomes a problem, and we'll know that as soon as the todo!()
macro panics.
from pineappl.
Unfortunately we will hit this case ... since I had already a very preliminary look at the cutting, I realized this already (but thought back then, that in fact you did NOT have this limitation): the case is DYE866P
- it is in the runcard: https://github.com/NNPDF/fktables/blob/7f34897005a90a6bcca38bf45a90b8dfb599dc99/data/runcards/NNPDF40_nnlo_as_01180_1000.yml#L32
- and it has a bin in the middle: https://github.com/NNPDF/fktables/blob/7f34897005a90a6bcca38bf45a90b8dfb599dc99/data/apfelcomb.dat#L200
from pineappl.
OK, no problem, I'll take care of it.
from pineappl.
Oh damn, you're right.
There are also a couple of CMS grids.
from pineappl.
Removing any bins should work since commit 50c12c4.
from pineappl.
Related Issues (20)
- Sort out Python wheel generation HOT 1
- CLI's `convolute` and Python `Grid::convolute_with_one` give different results HOT 3
- Fix Python metadata for Linux Python 3.6 wheel HOT 10
- recognizing collinear distribution type HOT 6
- Build and distribute CLI for Linux and macOS HOT 4
- Add machine-readable MC results and uncertainties to calculate interpolation error HOT 7
- Suppress LHAPDF's `stdout` when using `pineappl plot` HOT 1
- Add fastNLO exporter
- Add brew formula for PineAPPL HOT 2
- Add option to subcommand `write` to change the channel basis of a grid HOT 1
- Allow multiplicative combination of QCD and EW corrections
- Allow user-friendly specification of channels and orders
- Add possibility to change the exponents of each `Order` stored in a grid HOT 1
- Merging grids results in unexpected behavior HOT 10
- Extend the evolution to accommodate for two different EKOs
- Investigate `nano-gemm` crate to improve speed of linear algebra
- Document guarantees about the stability of the CLI output HOT 1
- Factorisation scales below Q2=100 not working in the fortran interface HOT 2
- Upgrade container to avoid problems with Node 20 used by Github actions HOT 1
- Make a conda release of v0.8.x HOT 18
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pineappl.