Coder Social home page Coder Social logo

Comments (4)

GaetanLepage avatar GaetanLepage commented on June 26, 2024 1

In what sense is it broken ?
The current implementation should not have a different effect than the previous one, which is to set some global values (vim.g.nord_*). Was it doing something more before ? Should it do something differently ?

We now use the mkVimPlugin helper but the namespace is properly set to colorschemes.

from nixvim.

GaetanLepage avatar GaetanLepage commented on June 26, 2024 1

Ah, this is caused by colorscheme = "nord"; was removed in this commit

Thus, in https://github.com/nix-community/nixvim/blob/main/modules/colorscheme.nix#L17, colorscheme is not set, causing nord not starting on launch

Indeed, thanks for finding out this bug !

from nixvim.

stepbrobd avatar stepbrobd commented on June 26, 2024

Ah, this is caused by colorscheme = "nord"; was removed in this commit

Thus, in https://github.com/nix-community/nixvim/blob/main/modules/colorscheme.nix#L17, colorscheme is not set, causing nord not starting on launch

from nixvim.

stepbrobd avatar stepbrobd commented on June 26, 2024

I'm not sure if the mkVimPlugin rewrite affected other colorschemes plugins tho, it might be better to take another look for those plugins

from nixvim.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.