Sequence contains no elements ParameterTypes.Last() about ninject.extensions.interception

[szaliszali]

The problem occurs for all explicitly implemented properties In this case, the name does not start with get because it will look like Full.Name.Of.Interface.Type.get_Property.

Location:

Ninject.Extensions.Interception/src/Ninject.Extensions.Interception/Infrastructure/Language/ExtensionsForMethodInfo.cs

Line 48 in a267001

var isGetMethod = method.Name.Substring(0, 3) == "get";

reproduction:

interface IInterface
{
	int Property { get; }
}

class Class : IInterface
{
	int IInterface.Property => -6; // crash
	public int Property => -6; // no crash
}

class Program
{
	static void Main()
	{
		var t = typeof(Class);
		foreach (var method in t.GetMethods(BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance))
		{
			Console.WriteLine($"Name: '{method.Name}'");
			Console.WriteLine(method.GetPropertyFromMethod(t));
		}
	}
}

My first guess would be look for the last dot in Name first, and only then check for get prefix. Also, the length<4 condition must be revisited.

Naive attempt to fix the method:

public static PropertyInfo GetPropertyFromMethod(this MethodInfo method, Type implementingType)
{
	if (!method.IsSpecialName)
	{
		return null;
	}

	var fullName = method.Name.AsSpan();
	var lastPeriod = fullName.LastIndexOf('.');
	var interfaceNameWithPeriod = fullName[..(lastPeriod + 1)];
	var name = fullName[(lastPeriod + 1)..];

	if (name.Length < 4)
	{
		return null;
	}
	var isGetMethod = name.StartsWith("get", StringComparison.InvariantCulture);

	var returnType = isGetMethod ? method.ReturnType : method.GetParameterTypes().Last();
	var indexerTypes = isGetMethod ? method.GetParameterTypes() : method.GetParameterTypes().SkipLast(1);

	var propertyName = $"{interfaceNameWithPeriod}{name[4..]}";
	return implementingType.GetProperty(propertyName, DefaultBindingFlags, null, returnType, indexerTypes.ToArray(), null);
}