Coder Social home page Coder Social logo

Comments (1)

szaliszali avatar szaliszali commented on July 26, 2024

The problem occurs for all explicitly implemented properties In this case, the name does not start with get because it will look like Full.Name.Of.Interface.Type.get_Property.

Location:

reproduction:

interface IInterface
{
	int Property { get; }
}

class Class : IInterface
{
	int IInterface.Property => -6; // crash
	public int Property => -6; // no crash
}

class Program
{
	static void Main()
	{
		var t = typeof(Class);
		foreach (var method in t.GetMethods(BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance))
		{
			Console.WriteLine($"Name: '{method.Name}'");
			Console.WriteLine(method.GetPropertyFromMethod(t));
		}
	}
}

My first guess would be look for the last dot in Name first, and only then check for get prefix. Also, the length<4 condition must be revisited.

Naive attempt to fix the method:

public static PropertyInfo GetPropertyFromMethod(this MethodInfo method, Type implementingType)
{
	if (!method.IsSpecialName)
	{
		return null;
	}

	var fullName = method.Name.AsSpan();
	var lastPeriod = fullName.LastIndexOf('.');
	var interfaceNameWithPeriod = fullName[..(lastPeriod + 1)];
	var name = fullName[(lastPeriod + 1)..];

	if (name.Length < 4)
	{
		return null;
	}
	var isGetMethod = name.StartsWith("get", StringComparison.InvariantCulture);

	var returnType = isGetMethod ? method.ReturnType : method.GetParameterTypes().Last();
	var indexerTypes = isGetMethod ? method.GetParameterTypes() : method.GetParameterTypes().SkipLast(1);

	var propertyName = $"{interfaceNameWithPeriod}{name[4..]}";
	return implementingType.GetProperty(propertyName, DefaultBindingFlags, null, returnType, indexerTypes.ToArray(), null);
}

from ninject.extensions.interception.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.