Comments (3)
Do you have the WINDOW_UPDATE sizes that were sent, both for the connection and each individual streams?
from cowboy.
Do you have the WINDOW_UPDATE sizes that were sent, both for the connection and each individual streams?
Does a PCAP help? The data comes from a load generator that fills it with pseudo random values, therefore no problem sharing it here.
cowboy-h2-window-update.pcapng.gz
- connection window size is exceeded in frame # 199
- connection WINDOW_UPDATE is in frame # 305 and cowboy start sending stream WINDOW_UPDATEs immediately afterwards
The client in this case was gun
with default settings.
NOTE: this particular PCAP also has the problem that it exceeded the max_received_frame_rate
, but that should not be relevant to the issue.
from cowboy.
Yes that's perfect, thank you.
Considering the increment, I think it's just Cowboy handlers that have called read_body
which defaults to 8MB read body size. Because 8MB is more than the current stream's window, Cowboy increases it preemptively to let the client upload without being blocked. Because many streams try to read bodies at the same time, Cowboy simply has to send many WINDOW_UPDATE frames.
Note that this only happens after the handlers have started calling read_body
as Cowboy will not increase the window before to avoid being overloaded, as well as to avoid using resources if the body ends up discarded. This is why you end up with a split DATA frame in 3.
Cowboy does not loop over all streams sending a WINDOW_UPDATE, but each stream may independently send it. It appears weird because of the nature of the test.
In practice you may reduce the size read by read_body
to avoid this. If you expect the body to be below, say, 10K, then set that as the length
option and WINDOW_UPDATE frames will not be sent.
from cowboy.
Related Issues (20)
- Reject responses that have explicit set-cookie HOT 7
- gunsmoke = gun + cowboy + tls + websocket HOT 3
- when use cowboy:start_tls can not connect HOT 7
- cowboy_clear's protocols option
- Document range requests in cowboy_rest and cowboy_static HOT 1
- 2.10 Getting Started: Makefile issue -- No rule to make target 'run' HOT 2
- Rewrite ws_autobahn to no longer use autobahn-testsuite HOT 2
- I want to use Cowboy 2.11's Websocket over HTTP/2 feature, How do I configure nginx HOT 2
- Apply routing constraint to […] bind? HOT 3
- Is cowboy affected by CVE-2023-46118 ? HOT 1
- Cookie Flexiblity HOT 2
- Response cookies must be set using cowboy_req HOT 1
- content_types_provided should be allowed to return the empty list when no Accept header is specified HOT 6
- Use async cancel_timer where applicable HOT 1
- Adding metadata/labels to a route? HOT 2
- which erlang version is supported? HOT 1
- Fix introduction supported OTP versions
- Add `licenses` to `.app` for `rebar3_sbom` HOT 11
- Is there a graceful way to drain a keep-alive connection server side? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cowboy.