24c08 and EEPROM24XX_Save about ee24

[nimaltd]

hello. did you config eeprom24xxconfig.h ?
#define _EEPROM_SIZE_KBIT 8

[kko123]

sure. I think the error in (uint16_t)_EEPROM_ADR|(Address&0x0003),Address>>2
High address bits must be in HW_ADR, but you used low. What do you think?

[nimaltd]

Please test that and tell me. I dont have 2408 now . Thank youOn Sep 8, 2019 2:57 PM, kko123 <[email protected]> wrote:sure. I think the error in (uint16_t)_EEPROM_ADR|(Address&0x0003),Address>>2 High address bits must be in HW_ADR, but you used low. What do you think? —You are receiving this because you commented.Reply to this email directly, view it on GitHub, or mute the thread.

[igorzhur727]

Hello!
Thank you for your work!
But let me amend.
If we use a 24LC16 chip with a page size of 16 bytes, then when writing 4 bytes from address 14, 2 bytes will be written to addresses 14 and 15 and the other two bytes will be written at the beginning of the page to addresses 0 and 1. This memory feature is described in the datasheet. I corrected the code to write correctly.

bool EE24xx_Write(uint16_t address, uint8_t *data, size_t len, uint32_t timeout)
{
uint16_t p, b, w;
uint16_t start_num_of_page;
uint16_t end_num_of_page;
uint16_t end_adr_of_page;
uint32_t startTime = HAL_GetTick();
// Если память занята то ждем тайм-аут
while (ee24_lock == 1)
{
if (HAL_GetTick() - startTime >= timeout)
return false;
ee24_delay(1);
}
//------------------------------------------------------------------------------
ee24_lock = 1;
//------------------------------------------------------------------------------
#if (_EEPROM_USE_WP_PIN==1)
HAL_GPIO_WritePin(_EEPROM_WP_GPIO, _EEPROM_WP_PIN,GPIO_PIN_RESET);
#endif
//------------------------------------------------------------------------------
while(1)
{
p = len / _EEPROM_PSIZE; // число страниц для записи
b = len % _EEPROM_PSIZE; // остаток байт на странице

if( p > 0) w = _EEPROM_PSIZE;   // Если число записываемых байт больше чем размер страницы то пишем только одну страницу
else       w = b;               // Если число записываемых байт меньше чем размер страницы то пишем это число байт
//
start_num_of_page = (long)(address / _EEPROM_PSIZE);       // страница где начинается запись
end_num_of_page   =(long)((address+w) / _EEPROM_PSIZE);    // страница где заканчивается запись
//
if (end_num_of_page > start_num_of_page) 
{ // данные на страницу не вмещаются. пишем их раздельно. Вычисляем остаток байт на странице.
  end_adr_of_page = ((start_num_of_page+1) * _EEPROM_PSIZE)-1; // Конечный адресс на странице.
  w = (end_adr_of_page - address)+1; 
}

#if ((_EEPROM_SIZE_KBIT==1) || (_EEPROM_SIZE_KBIT==2))
if (HAL_I2C_Mem_Write(&_EEPROM_I2C, _EEPROM_ADDRESS, address, I2C_MEMADD_SIZE_8BIT, data, w, 100) == HAL_OK)
#elif (_EEPROM_SIZE_KBIT==4)
if (HAL_I2C_Mem_Write(&_EEPROM_I2C, _EEPROM_ADDRESS | (((address & 0x0100) >> 7)), (address & 0xff), I2C_MEMADD_SIZE_8BIT, data, w, 100) == HAL_OK)
#elif (_EEPROM_SIZE_KBIT==8)
if (HAL_I2C_Mem_Write(&_EEPROM_I2C, _EEPROM_ADDRESS | (((address & 0x0300) >> 7)), (address & 0xff), I2C_MEMADD_SIZE_8BIT, data, w, 100) == HAL_OK)
#elif (_EEPROM_SIZE_KBIT==16)
if (HAL_I2C_Mem_Write(&_EEPROM_I2C, _EEPROM_ADDRESS | (((address & 0x0700) >> 7)), (address & 0xff), I2C_MEMADD_SIZE_8BIT, data, w, 100) == HAL_OK)		
#else
if (HAL_I2C_Mem_Write(&_EEPROM_I2C, _EEPROM_ADDRESS, address, I2C_MEMADD_SIZE_16BIT, data, w, 100) == HAL_OK)
#endif
{
  ee24_delay(10);
  len -= w;
  data += w;
  address += w;
  if (len == 0)
  {
    #if (_EEPROM_USE_WP_PIN==1)
    HAL_GPIO_WritePin(_EEPROM_WP_GPIO, _EEPROM_WP_PIN, GPIO_PIN_SET);
    #endif
    ee24_lock = 0;
    return true;
  }
  if (HAL_GetTick() - startTime >= timeout) 
  {
    ee24_lock = 0;
    return false;
  }
}
else
{
  #if (_EEPROM_USE_WP_PIN==1)
  HAL_GPIO_WritePin(_EEPROM_WP_GPIO, _EEPROM_WP_PIN, GPIO_PIN_SET);
  #endif
  ee24_lock = 0;
  return false;		
}

}
}

[nimaltd]

@igorzhur727 . this is fixed now. please try again with 2.1.0