Comments (6)
Some example:
messageHub.SubscribeAsync<CoolData>(CoolDataUpdated);
private async Task CoolDataUpdated(CoolData data)
{
await DoSmthWithCoolDataAsync(data);
}
Now, I have to use Wait
.
from easy.messagehub.
messageHub.Subscribe
is CPU bound and therefore does not require an async implementation; However you can certainly modify your handler method to offload the received message to one or more consumer threads.
I cannot think of a valid use-case for adding async overloads to the library.
from easy.messagehub.
I don't completely understand what is CPU bound in this context. I will google about it. But, if you think that async overloads don't needed, then maybe add a overloads for different async handles, in order to avoid using Wait
. So, I belive adding Func<Task>
delegate helps me avoid Wait
method and allows use await
. BTW, I use library in the ASP.NET Core project.
from easy.messagehub.
Inside your CoolDataUpdated
method pass the payload to another method with the async Task
signature, there you can await
it with no problem.
Also in your example, you do not need to include the Task
as the return type. The following works with no problem:
MessageHub.Instance.Subscribe<string>(Handle);
private async void Handle(string payload)
{
await Task.Delay(TimeSpan.FromMilliseconds(100));
Console.WriteLine(payload);
}
I am unable to understand why you would need to use such pattern.
from easy.messagehub.
It's a bad idea to use async void
especially in the ASP.NET Core. You can read answers from this Stack Overflow question.
from easy.messagehub.
None of those points apply to your example hence why I said "in your example" either way there are many ways to skin the cat you intend to skin. So either use the example I have provided or offload to another method.
from easy.messagehub.
Related Issues (20)
- Registering IMessageHub with MessageHub HOT 1
- Subscribing a runtime type HOT 5
- Subscriber is receiving 3 messages when publisher is only sending 1 HOT 7
- Publish & Subscribe from different Project? HOT 2
- Non-singleton instances HOT 8
- Sometimes Unsubscribe method hangs HOT 6
- How to setup one Server with Many cleints between ASP Core web and .net Console service HOT 1
- System.ObjectDisposedException: ThreadLocal object has been deleted. HOT 1
- NuGet package?
- Async handlers HOT 2
- Get MessageHub to play nicely with Autofac in a web application HOT 1
- Conditional subscription HOT 6
- Unflexible detection of the given type HOT 4
- Support for async actions HOT 2
- Add an async publisher HOT 4
- Available for dotnet core? HOT 2
- MessageHub is holding objects in Memory HOT 18
- UnSubscribe method causes ArgumentNullException HOT 1
- Publish and subscribe from different threads HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from easy.messagehub.