Question: BufferHandler config about monolog-factory

[nikolaposa]

@alexpts Why do you think that is needed, what change you would made? MonologFactory already requires nikolaposa/cascader:^1.0 so running: composer update --with-dependencies nikolaposa/monolog-factory should update Cascader to the latest version.

[alexpts]

I will make PR for repo cascader

[alexpts]

I prepare PR. It will work:

$loggerFactory = new LoggerFactory();

$logger = $loggerFactory->createLogger('logger', [
    'handlers' => [
        [
            'name' => BufferHandler::class,
            'options' => [
                'handler' => [
                    '__class__' => NativeMailerHandler::class,
                    'options' => [
                        'to' => '[email protected]',
                        'subject' => 'Test',
                        'from' => '[email protected]',
                        'level' => Logger::ALERT,
                        'formatter' => [
                            'name' => HtmlFormatter::class,
                        ],
                    ],
                ]
            ]
        ]
    ]
]);

[nikolaposa]

Hi @alexpts, are you sure your first example doesn't work? What do you end up with after running it? I have a similar case covered in my tests: https://github.com/nikolaposa/monolog-factory/blob/master/tests/LoggerFactoryTest.php#L225

[nikolaposa]

Ok, I got it, it won't work in case of interface parameter type hints. Thanks for reporting this!

[alexpts]

I will wait release with updated version cascader package. Thanks!

[nikolaposa]

Issue is fixed with the latest (1.1.0) release of nikolaposa/cascader. Please update.

[alexpts]

I mean new version nikolaposa/monolog-factory package :)

[alexpts]

You are right :)

[nikolaposa]

But you know what, perhaps I should explicitly require cascader:^1.1 and bump patch version of MonologFactory so that folks are aware of that change. I think I'll do that.

[nikolaposa]

@alexpts Done. Can you please try running composer update nikolaposa/monolog-factory in your project and see whether both Monolog Factory and Cascader will be updated? Thanks.

[alexpts]

Thanks!

[alexpts]

New correct config:

$loggerFactory = new LoggerFactory();

$logger = $loggerFactory->createLogger('logger', [
    'handlers' => [
        [
            'name' => BufferHandler::class,
            'options' => [
                'handler' => [
                    '__class__' => NativeMailerHandler::class,
                    'to' => '[email protected]',
                    'subject' => 'Test',
                    'from' => '[email protected]',
                    'level' => Logger::ALERT,
                    'formatter' => [
                        'name' => HtmlFormatter::class,
                    ],
                ]
            ]
        ]
    ]
]);

[nikolaposa]

Cool, thanks a lot for the help