Coder Social home page Coder Social logo

Comments (4)

noogen avatar noogen commented on June 10, 2024

Yes, but It hasn't been on my priority because we use purchased SSL in our Production.

Something like this? https://forum.vestacp.com/viewtopic.php?f=19&t=13057

Lets brainstorm. Problem is, we do not know the domain that Vesta will be using. Should we request a docker environment variable for this domain/hostname or $VESTA_DOMAIN?

The init script would check:

  1. if exists $VESTA_DOMAIN, setup domain on the admin account and acquire Letsencrypt SSL.
  2. link the SSL to vesta admin and exim4.
  3. link for any other service that require the SSL too?

Someone has to test this feature since I don't really use Vesta for email.

from vestacp.

lsgd avatar lsgd commented on June 10, 2024

Maybe we could reuse the hostname provided to start the docker container.
My main purpose for this container is running a mail server in docker.

Unfortunately it's not (easily) possible to change the hostname of a docker container while running it. But you can provide an own hostname during startup which solves this problem.

Therefore, we could just fallback to the hostname and have a $VESTA_DOMAIN in case someone wants to overwrite it with another value.
What do you think?

As an example for the hostname, here is my docker-compose.yml:

vestacp:
  container_name: vestacp
  hostname: my-domain.com
  image: niiknow/vestacp
  restart: always
  ports:
    - "25:25"
    - "110:110"
    - "143:143"
    - "465:465"
    - "587:587"
    - "993:993"
    - "995:995"
    - "8083:8083"
  expose:
    - "80"
  volumes:
    - /opt/data/mail/vestacp/vesta:/vesta:rw
    - /opt/data/mail/vestacp/home:/home:rw
    - /opt/data/mail/vestacp/backup:/backup:rw

from vestacp.

noogen avatar noogen commented on June 10, 2024

Done, here's the script: https://github.com/niiknow/vestacp/blob/master/files/sysprepz/admin/bin/vesta-auto-ssl.sh

I've added $VESTA_DOMAIN

See example here: https://github.com/niiknow/vestacp/blob/master/docker-compose.yml

While testing, I discover a bug and patched: https://github.com/niiknow/vestacp/blob/master/Dockerfile#L360

Reported here: outroll/vesta#1253

from vestacp.

lsgd avatar lsgd commented on June 10, 2024

Nice! Thank you for implementing it!

from vestacp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.