Coder Social home page Coder Social logo

Comments (6)

nihui avatar nihui commented on May 18, 2024

In fact, I've implemented ESRGAN and found that the quality on noisy JPG image is very poor, so it's not released.

reference issue
xinntao/ESRGAN#5
xinntao/ESRGAN#19

from srmd-ncnn-vulkan.

xpirad avatar xpirad commented on May 18, 2024

@nihui Please check out this page under section JPG compression
https://upscale.wiki/wiki/Model_Database
There are models trained specifically to remove jpeg compression artifacts.
For usage on jpegs, i suppose one can first de-artifact and then upscale. It's also mentioned in your link ESRGAN#5

from srmd-ncnn-vulkan.

nihui avatar nihui commented on May 18, 2024

In theory, it could produce better result with more specifically trained models and fine-grained hyper parameters settings.
However, it is a big trouble for normal users to figure out how to choose the proper model and settings.
It is even harder to play around with two models of different purpose, denoise and superresolution.

This project aims to provide a simple way to achieve image upscaling and denoising, so an end-to-end model is preferred.

from srmd-ncnn-vulkan.

xpirad avatar xpirad commented on May 18, 2024

Well, it's not in theory. I've tried it and indeed it can produce better results. End-to-end doesn't always promise optimal quality. I suggest you try out JPG (80-100%) B for de-artifact and FireAlpha for SR using the fork over here https://github.com/BlueAmulet/ESRGAN
Maybe one can trade convenience for quality? After all, it is high quality photo that user would really want. And it's not that difficult, just run two models sequentially.
Please do reconsider. @nihui

from srmd-ncnn-vulkan.

WalkerMx avatar WalkerMx commented on May 18, 2024

@nihui This thread is dead, but it is the best place to ask.

How general was your implementation? Could it accept different models?

If so, I'd have a proposition. My project also aims to make the process simple (I think you've seen it ^^; ).

Would you consider letting me test your ESRGAN implementation with my program?

Even if it wasn't quite 'end-to-end', I'm sure I could make the process completely seamless.

from srmd-ncnn-vulkan.

nihui avatar nihui commented on May 18, 2024

@nihui This thread is dead, but it is the best place to ask.

How general was your implementation? Could it accept different models?

If so, I'd have a proposition. My project also aims to make the process simple (I think you've seen it ^^; ).

Would you consider letting me test your ESRGAN implementation with my program?

Even if it wasn't quite 'end-to-end', I'm sure I could make the process completely seamless.

hello

In fact, the ReaSR model architecture is identical to the ESRGAN ones, you can assume it is yet another ESRGAN model
Thus, it is possible to convert most of the models here https://upscale.wiki/wiki/Model_Database to ncnn, and then use them with the realsr-ncnn-vulkan tool. I have converted some of them, and these ones work as expected.

However, as the model arch is identical, the runtime speed is identical too.
Because the RealSR produces much better result, I don't think it makes sense to use these ESRGAN models for general purposes.

But there are a few interesting models, such as jpeg-denoise, deblur, etc
If necessary, you can leave a message in realsr github issue

😄

from srmd-ncnn-vulkan.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.