acquire serial device might be called wihtout mSerialDevice.close(); called on function SyncingService.handleActionSync about android-uploader

[bewest]

Nice, thanks for reviewing and reporting bugs!

Yes, we love contributors. :-)

[ktind]

Please - feel free to submit a PR

[bewest]

If you are new to github and pull requests (PR), there are lots of guides around the web.
We are working on one as well, apologies if it's new and confusing!

[tzachi-dar]

There are two approaces to solve this bug:

First, using try-finaly. This is the more native java approach but was
never used in the android-uploader code.

The second one is using a more tradional approach (that is remembering if
the lock was taken). This seems to be the approach that was using in this
project.

What type of solution do you prefer? I can easily do both.

Thanks
Tzachi

On Tue, Oct 28, 2014 at 7:42 PM, Ben West [email protected] wrote:

If you are new to github and pull requests (PR), there are lots of guides
around the web.
We are working on one as well, apologies if it's new and confusing!

—
Reply to this email directly or view it on GitHub
#50 (comment)
.

[ktind]

This lead me right to the issue. We want to get this fixed quickly. After reviewing it, I believe finally is the best method. Please submit a PR ASAP and we'll take it from there.

Great find!

[tzachi-dar]

Just created a PR, please let me know if there is any problem with it.

Thanks
Tzachi