Runs, renders, but "nothing to commit" about render-md-mermaid

[danielloader]

Excited for v2 release now, thanks.

[nielsvaneck]

not sure what your reproduction steps are, but have you tried removing the example images or changing the graph definitions?

[danielloader]

Think I can shine some light on this @lswank

$ docker run -it -v /path/to/diagrams:/data --entrypoint bash minlag/mermaid-cli
mermaidcli@64bbea1ff322:/$ find . -name mmdc
./home/mermaidcli/node_modules/.bin/mmdc
./home/mermaidcli/.cache/yarn/v6/.tmp/0be863b9afb222f53eb609791cf5e2c4/.bin/mmdc
./home/mermaidcli/.cache/yarn/v6/npm-@mermaid-js-mermaid-cli-8.11.0-bbcd91e448f003155975601a65885ed153898298/node_modules/@mermaid-js/mermaid-cli/.bin/mmdc
mermaidcli@64bbea1ff322:/$ stat /usr/local/bin/mmdc
stat: cannot stat '/usr/local/bin/mmdc': No such file or directory

https://github.com/mermaid-js/mermaid-cli/blob/master/Dockerfile#L15

Seems to be passing as successful in the script despite it failing to find a binary inside the docker image being used, I suspect the path to a mmdc entrypoint changed in minlag/mermaid-cli at some point, and this action is using the latest tag.

EDIT: here's the change made:
mermaid-js/mermaid-cli@8888b19#diff-dd2c0eb6ea5cfc6c4bd4eac30934e2d5746747af48fef6da689e85b752f39557L13

Though interestingly May26th and the original issue is from Feb, but here we are.

[danielloader]

#2 Put in a pull request to catch these issues in future, would have bailed with non zero exit code and failed the pipeline if it couldn't find mmdc

[nielsvaneck]

Thank you, @danielloader !

[danielloader]

Just need to change the binary location in the bash script and we should be set.

[nielsvaneck]

Done!

…

On Thu, Jul 15, 2021 at 9:58 AM Daniel Loader ***@***.***> wrote: Just need to change the binary location in the bash script and we should be set. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAACZDWD2GDHBGM7442XHCTTX4HRZANCNFSM4YGDYZ4A> .