Discussion, previousVersion or currentVersion? about sequelize-paper-trail

[mhaamann]

The down side is that you loose track on who did the change and without the RevisionChangeModel you cannot see what was updated. This is also bad :(

What if we introduce a new coloum 'snapshot' where the previousVersion is stored. The 'currentVersion' will still be stored in document.
We could furthermore improve paper-trail by loading the full object from db automatically for the snapshot instead of relying that previousVersion actually contains a fully loaded object.

At least in our codebase we have a lot of places where we load an object and only specify 1-2 attributes instead of fully loading all attributes.

[nielsgl]

Yeah there are arguments to do it either way. The downside of storing {} as initial state is that it doesn't add much value because when a model is created we would immediately need to add 2 rows in the Revisions table, one with {} and one with the model as it is when it is created.
Currently, the Revisions table already contains the full model at each step in the document column, so when I create a user, say {first_name: 'John', last_name: 'Doe'} it will contain the full model will be stored there as revision 1, and when I update the first name of the user, a row is added to the revisions table and then the document column contains the new model, say {first_name: 'Jane', last_name: 'Doe'} and the RevisionChanges will have a row where path = 'first_name', document will contain the previous and current values, so both 'John' and Jane' and will be associated with Revision id = 2, this enables us to actually search for every snapshot in which the first_name was either 'John' and it was updated to something else (lhs: 'John') or when it was something else and updated to 'John' (rhs: 'John')